linux-kernel - RE: [PATCH] media: renesas: rcar_drif: fix device node reference leak in rcar_drif_bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB12093F701335B99CF358ABD61C201A@TYCPR01MB12093.jpnprd01.prod.outlook.com>
Date: Wed, 3 Sep 2025 17:14:46 +0000
From: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To: Miaoqian Lin <linmq006@...il.com>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>,
	magnus.damm <magnus.damm@...il.com>, Ramesh Shanmugasundaram
	<ramesh.shanmugasundaram@...renesas.com>, Hans Verkuil <hverkuil@...nel.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] media: renesas: rcar_drif: fix device node reference leak
 in rcar_drif_bond_enabled

> From: Miaoqian Lin <linmq006@...il.com>
> Sent: 03 September 2025 14:37
> To: Fabrizio Castro <fabrizio.castro.jz@...esas.com>; Mauro Carvalho Chehab <mchehab@...nel.org>; Geert
> Uytterhoeven <geert+renesas@...der.be>; magnus.damm <magnus.damm@...il.com>; Ramesh Shanmugasundaram
> <ramesh.shanmugasundaram@...renesas.com>; Hans Verkuil <hverkuil@...nel.org>; linux-
> media@...r.kernel.org; linux-renesas-soc@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: linmq006@...il.com; stable@...r.kernel.org
> Subject: [PATCH] media: renesas: rcar_drif: fix device node reference leak in rcar_drif_bond_enabled
> 
> The function calls of_parse_phandle() which returns
> a device node with an incremented reference count. When the bonded device
> is not available, the function
> returns NULL without releasing the reference, causing a reference leak.
> 
> Add of_node_put(np) to release the device node reference.
> The of_node_put function handles NULL pointers.
> 
> Found through static analysis by reviewing the doc of of_parse_phandle()
> and cross-checking its usage patterns across the codebase.
> 
> Fixes: 7625ee981af1 ("[media] media: platform: rcar_drif: Add DRIF support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>

> ---
>  drivers/media/platform/renesas/rcar_drif.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/renesas/rcar_drif.c b/drivers/media/platform/renesas/rcar_drif.c
> index fc8b6bbef793..c5d676eb1091 100644
> --- a/drivers/media/platform/renesas/rcar_drif.c
> +++ b/drivers/media/platform/renesas/rcar_drif.c
> @@ -1246,6 +1246,7 @@ static struct device_node *rcar_drif_bond_enabled(struct platform_device *p)
>  	if (np && of_device_is_available(np))
>  		return np;
> 
> +	of_node_put(np);
>  	return NULL;
>  }
> 
> --
> 2.35.1