linux-kernel - Re: [PATCH] audit: fix out-of-bounds read in audit_compare_dname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8e395d8a-2875-4f78-9118-facd5de09a30n@aisle.com>
Date: Wed, 3 Sep 2025 11:03:02 -0700 (PDT)
From: Disclosure <disclosure@...le.com>
To: Disclosure <disclosure@...le.com>
Cc: Paul Moore <paul@...l-moore.com>,
	"audit@...r.kernel.org" <audit@...r.kernel.org>,
	"torvalds@...uxfoundation.org" <torvalds@...uxfoundation.org>,
	"eparis@...hat.com" <eparis@...hat.com>,
	"security@...nel.org" <security@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stanislav Fort <stanislav.fort@...le.com>
Subject: Re: [PATCH] audit: fix out-of-bounds read in
 audit_compare_dname_path

Hi Paul,

Yes, please go ahead and change the Signed-off-by to:
Signed-off-by: Stanislav Fort <stanislav.fort@...le.com>

Sorry for the slight delay and thanks for the quick review, testing, and 
for adding the Fixes tag.

Best wishes,
Stanislav Fort
Aisle Research

On Wednesday, September 3, 2025 at 6:16:59 PM UTC+3 Paul Moore wrote:

> On Tue, Sep 2, 2025 at 2:52 PM Paul Moore <paul@...l-moore.com> wrote:
> > On Tue, Sep 2, 2025 at 2:50 PM Paul Moore <paul@...l-moore.com> wrote:
> > > On Tue, Sep 2, 2025 at 7:00 AM Stanislav Fort <
> stanislav.fort@...le.com> wrote:
> > > >
> > > > When a watch on dir=/ is combined with an fsnotify event for a
> > > > single-character name directly under / (e.g., creating /a), an
> > > > out-of-bounds read can occur in audit_compare_dname_path().
> > > >
> > > > The helper parent_len() returns 1 for "/". In 
> audit_compare_dname_path(),
> > > > when parentlen equals the full path length (1), the code sets p = 
> path + 1
> > > > and pathlen = 1 - 1 = 0. The subsequent loop then dereferences
> > > > p[pathlen - 1] (i.e., p[-1]), causing an out-of-bounds read.
> > > >
> > > > Fix this by adding a pathlen > 0 check to the while loop condition
> > > > to prevent the out-of-bounds access.
> > > >
> > > > Reported-by: Stanislav Fort <disclosure@...le.com>
> > > > Suggested-by: Linus Torvalds <torvalds@...uxfoundation.org>
> > > > Signed-off-by: Stanislav Fort <disclosure@...le.com>
> >
> > I also just noticed a disconnect on the email address. I can leave
> > the Reported-by email as disclosure@, but do you mind if I convert
> > your Signed-off-by email to stanislav.fort@?
>
> Stanislav, are you okay with changing your sign-off email to
> stanislav.fort@...le.com?
>
> --
> paul-moore.com
>

Content of type "text/html" skipped