linux-kernel - Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jpAm-KrS0k4be523ygbRMPjSDGgNas7ipwpd9kKacqKg@mail.gmail.com>
Date: Wed, 3 Sep 2025 20:36:19 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Osama Abdelkader <osama.abdelkader@...il.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, daniel.lezcano@...aro.org, rui.zhang@...el.com, 
	lukasz.luba@....com, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()

On Wed, Sep 3, 2025 at 7:29 PM Osama Abdelkader
<osama.abdelkader@...il.com> wrote:
>
> On Wed, Sep 03, 2025 at 04:21:35PM +0200, Rafael J. Wysocki wrote:
> > On Wed, Sep 3, 2025 at 4:04 PM Osama Abdelkader
> > <osama.abdelkader@...il.com> wrote:
> > >
> > > On Wed, Sep 03, 2025 at 01:50:03PM +0200, Rafael J. Wysocki wrote:
> > > > On Mon, Sep 1, 2025 at 5:06 PM Osama Abdelkader
> > > > <osama.abdelkader@...il.com> wrote:
> > > > >
> > > > > strcpy() is deprecated; use strscpy() instead.
> > > >
> > > > So why is it better to use strscpy() in this particular case?
> > >
> > > Thanks for the review. Technically, there is no change since both have const buf size,
> > > it's just for consistency with other drivers.
> >
> > $ cd linux-kernel-source
> > $ git grep strcpy | wc -l
> > 1187
> >
> > What kind of consistency do you mean?
>
> I mean in thermal subsystem, it's only this one.

So please add this information to the patch changelog.