linux-kernel - RE: [Intel-wired-lan] [PATCH v2] igb: Fix NULL pointer dereference in ethtool loopback test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB62417A30F7E247B971E917958B01A@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Wed, 3 Sep 2025 03:50:35 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: Tianyu Xu <xtydtc@...il.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>
CC: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Tianyu Xu <tianyxu@...co.com>, "Loktionov,
 Aleksandr" <aleksandr.loktionov@...el.com>, Joe Damato <joe@...a.to>
Subject: RE: [Intel-wired-lan] [PATCH v2] igb: Fix NULL pointer dereference in
 ethtool loopback test

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Tianyu Xu
> Sent: 12 August 2025 18:41
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; kuba@...nel.org; intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Tianyu Xu <tianyxu@...co.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Joe Damato <joe@...a.to>
> Subject: [Intel-wired-lan] [PATCH v2] igb: Fix NULL pointer dereference in ethtool loopback test
>
> The igb driver currently causes a NULL pointer dereference when executing the ethtool loopback test. This occurs because there is no associated q_vector for the test ring when it is set up, as interrupts are typically not added to the test rings.
>
> Since commit 5ef44b3cb43b removed the napi_id assignment in __xdp_rxq_info_reg(), there is no longer a need to pass a napi_id to it.
> Therefore, simply use 0 as the last parameter.
>
> Fixes: 2c6196013f84 ("igb: Add AF_XDP zero-copy Rx support")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Joe Damato <joe@...a.to>
> Signed-off-by: Tianyu Xu <tianyxu@...co.com>
> ---
> Thanks to Aleksandr and Joe for your feedback. I have added the Fixes tag and formatted the lines to 75 characters based on your comments.
>
> drivers/net/ethernet/intel/igb/igb_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)