[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250903185921.1785167-1-vishal.moola@gmail.com>
Date: Wed, 3 Sep 2025 11:59:14 -0700
From: "Vishal Moola (Oracle)" <vishal.moola@...il.com>
To: linux-mm@...ck.org
Cc: linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
linux-block@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linuxppc-dev@...ts.ozlabs.org,
linux-riscv@...ts.infradead.org,
linux-efi@...r.kernel.org,
virtualization@...ts.linux.dev,
"Vishal Moola (Oracle)" <vishal.moola@...il.com>,
Justin Sanders <justin@...aid.com>,
Jens Axboe <axboe@...nel.dk>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Andy Lutomirski <luto@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Madhavan Srinivasan <maddy@...ux.ibm.com>,
Michael Ellerman <mpe@...erman.id.au>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
"Michael S. Tsirkin" <mst@...hat.com>,
David Hildenbrand <david@...hat.com>
Subject: [PATCH v3 0/7] Cleanup free_pages() misuse
free_pages() is supposed to be called when we only have a virtual address.
__free_pages() is supposed to be called when we have a page.
There are a number of callers that use page_address() to get a page's
virtual address then call free_pages() on it when they should just call
__free_pages() directly.
Add kernel-docs for free_pages() to help callers better understand which
function they should be calling, and replace the obvious cases of
misuse.
-----------------
Based on mm-new, I intend to have all of these taken through the mm tree.
I've split the patches into separate subsystems to make it easier to
resolve conflicts, but there aren't any functional changes.
v3:
- Collect some Reviewed-by Tags
- Replace remaining free_page() calls in patch 7 (all other patches
are unchanged from v2)
- Add all appropriate mailing lists that were missing from v2
v2:
- Reference __get_free_pages() instead of alloc_pages() in the
free_pages() kernel-doc
- Get some Reviewed-by tags
- cc the subsystem maintainers related to specific patches
Vishal Moola (Oracle) (7):
mm/page_alloc: Add kernel-docs for free_pages()
aoe: Stop calling page_address() in free_page()
x86: Stop calling page_address() in free_pages()
riscv: Stop calling page_address() in free_pages()
powerpc: Stop calling page_address() in free_pages()
arm64: Stop calling page_address() in free_pages()
virtio_balloon: Stop calling page_address() in free_pages()
arch/arm64/mm/mmu.c | 2 +-
arch/powerpc/mm/book3s64/radix_pgtable.c | 2 +-
arch/riscv/mm/init.c | 4 ++--
arch/x86/mm/init_64.c | 2 +-
arch/x86/platform/efi/memmap.c | 2 +-
drivers/block/aoe/aoecmd.c | 2 +-
drivers/virtio/virtio_balloon.c | 8 +++-----
mm/page_alloc.c | 9 +++++++++
8 files changed, 19 insertions(+), 12 deletions(-)
--
2.51.0
Powered by blists - more mailing lists