lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9387ed0a6d4e4c77ffd0f7aee55eaa1ff6ecd22e.camel@crapouillou.net>
Date: Wed, 03 Sep 2025 21:18:09 +0200
From: Paul Cercueil <paul@...pouillou.net>
To: bmasney@...hat.com, Michael Turquette <mturquette@...libre.com>, Stephen
 Boyd <sboyd@...nel.org>, Sudeep Holla <sudeep.holla@....com>, Cristian
 Marussi	 <cristian.marussi@....com>, Chen Wang <unicorn_wang@...look.com>,
 Inochi Amaoto	 <inochiama@...il.com>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>,  Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Keguang Zhang	 <keguang.zhang@...il.com>, Taichi Sugaya
 <sugaya.taichi@...ionext.com>,  Takao Orito <orito.takao@...ionext.com>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer	 <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,  Fabio Estevam
 <festevam@...il.com>, Jacky Huang <ychuang3@...oton.com>, Shan-Chun Hung
 <schung@...oton.com>,  Vladimir Zapolskiy	 <vz@...ia.com>, Piotr
 Wojtaszczyk <piotr.wojtaszczyk@...esys.com>, Paul Walmsley
 <paul.walmsley@...ive.com>, Samuel Holland <samuel.holland@...ive.com>,
 Yixun Lan	 <dlan@...too.org>, Steen Hegelund
 <Steen.Hegelund@...rochip.com>, Daniel Machon	
 <daniel.machon@...rochip.com>, UNGLinuxDriver@...rochip.com, Orson Zhai	
 <orsonzhai@...il.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan
 Zhang <zhang.lyra@...il.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue	 <alexandre.torgue@...s.st.com>, Michal Simek
 <michal.simek@....com>, Maxime Ripard <mripard@...nel.org>, Andreas
 Färber <afaerber@...e.de>,  Manivannan Sadhasivam	
 <mani@...nel.org>, Sven Peter <sven@...nel.org>, Janne Grunau
 <j@...nau.net>,  Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa
 <neal@...pa.dev>, Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,  Ray Jui
 <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Max
 Filippov <jcmvbkbc@...il.com>, Matthias Brugger	 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno	 <angelogioacchino.delregno@...labora.com>,
 Daniel Palmer <daniel@...ngy.jp>,  Romain Perier <romain.perier@...il.com>,
 Andrew Lunn <andrew@...n.ch>, Gregory Clement	
 <gregory.clement@...tlin.com>, Sebastian Hesselbarth	
 <sebastian.hesselbarth@...il.com>, Bjorn Andersson <andersson@...nel.org>, 
 Geert Uytterhoeven <geert+renesas@...der.be>, Heiko Stuebner
 <heiko@...ech.de>, Andrea della Porta <andrea.porta@...e.com>,  Krzysztof
 Kozlowski	 <krzk@...nel.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi	 <cw00.choi@...sung.com>, Alim Akhtar
 <alim.akhtar@...sung.com>, Qin Jian	 <qinjian@...lus1.com>, Viresh Kumar
 <vireshk@...nel.org>, Ulf Hansson	 <ulf.hansson@...aro.org>, Luca Ceresoli
 <luca.ceresoli@...tlin.com>, Alex Helms	 <alexander.helms.jy@...esas.com>,
 Linus Walleij <linus.walleij@...aro.org>,  Liviu Dudau
 <liviu.dudau@....com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Nobuhiro
 Iwamatsu	 <nobuhiro1.iwamatsu@...hiba.co.jp>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	sophgo@...ts.linux.dev, linux-mips@...r.kernel.org, imx@...ts.linux.dev, 
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev, 
	linux-stm32@...md-mailman.stormreply.com, patches@...nsource.cirrus.com, 
	linux-actions@...ts.infradead.org, asahi@...ts.linux.dev, 
	linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, soc@...ts.linux.dev
Subject: Re: [PATCH 022/114] clk: ingenic: cgu: convert from round_rate() to
 determine_rate()

Hi Brian,

Le lundi 11 août 2025 à 11:18 -0400, Brian Masney via B4 Relay a
écrit :
> From: Brian Masney <bmasney@...hat.com>
> 
> The round_rate() clk ops is deprecated, so migrate this driver from
> round_rate() to determine_rate() using the Coccinelle semantic patch
> on the cover letter of this series.
> 
> Signed-off-by: Brian Masney <bmasney@...hat.com>

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  drivers/clk/ingenic/cgu.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/clk/ingenic/cgu.c b/drivers/clk/ingenic/cgu.c
> index
> 0c9c8344ad1103b13337a26e14b0d5d5c340d705..91e7ac0cc3342e3552acb9d2ec0
> 0865a5234ad4f 100644
> --- a/drivers/clk/ingenic/cgu.c
> +++ b/drivers/clk/ingenic/cgu.c
> @@ -174,14 +174,16 @@ ingenic_pll_calc(const struct
> ingenic_cgu_clk_info *clk_info,
>  		n * od);
>  }
>  
> -static long
> -ingenic_pll_round_rate(struct clk_hw *hw, unsigned long req_rate,
> -		       unsigned long *prate)
> +static int ingenic_pll_determine_rate(struct clk_hw *hw,
> +				      struct clk_rate_request *req)
>  {
>  	struct ingenic_clk *ingenic_clk = to_ingenic_clk(hw);
>  	const struct ingenic_cgu_clk_info *clk_info =
> to_clk_info(ingenic_clk);
>  
> -	return ingenic_pll_calc(clk_info, req_rate, *prate, NULL,
> NULL, NULL);
> +	req->rate = ingenic_pll_calc(clk_info, req->rate, req-
> >best_parent_rate,
> +				     NULL, NULL, NULL);
> +
> +	return 0;
>  }
>  
>  static inline int ingenic_pll_check_stable(struct ingenic_cgu *cgu,
> @@ -317,7 +319,7 @@ static int ingenic_pll_is_enabled(struct clk_hw
> *hw)
>  
>  static const struct clk_ops ingenic_pll_ops = {
>  	.recalc_rate = ingenic_pll_recalc_rate,
> -	.round_rate = ingenic_pll_round_rate,
> +	.determine_rate = ingenic_pll_determine_rate,
>  	.set_rate = ingenic_pll_set_rate,
>  
>  	.enable = ingenic_pll_enable,

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ