linux-kernel - Re: [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509031924363f3ca29e@mail.local>
Date: Wed, 3 Sep 2025 21:24:36 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string
 nxp,rtc-pcf2123

On 03/09/2025 14:24:10-0400, Frank Li wrote:
> On Wed, Sep 03, 2025 at 06:58:29PM +0200, Alexandre Belloni wrote:
> > On 03/09/2025 12:55:36-0400, Frank Li wrote:
> > > Add compatible string nxp,rtc-pcf2123, which style is not consistent with
> > > existed compatible string because existed driver and dts use
> > > nxp,rtc-pcf2123.
> > >
> > > Fix below CHECK_DTBS warning:
> > > arch/arm/boot/dts/nxp/imx/imx6q-evi.dtb: /soc/bus@...0000/spba-bus@...0000/spi@...8000/rtc@3: failed to match any schema with compatible: ['nxp,rtc-pcf2123']
> > >
> > > Signed-off-by: Frank Li <Frank.Li@....com>
> > > ---
> > >  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > index 11fcf0ca1ae07..595c20df6a411 100644
> > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > @@ -20,6 +20,7 @@ properties:
> > >        - nxp,pcf2127
> > >        - nxp,pcf2129
> > >        - nxp,pcf2131
> > > +      - nxp,rtc-pcf2123
> >
> > Nope, you need to fix the devicetree.
> 
> Oh, driver drivers/rtc/rtc-pcf2123.c also use nxp,rtc-pcf2123. For such old
> devices, generally keep it as it.
> 
> Maybe DT team members provide more professional comments for it.

It is there for DT ABI compatibility, we don't need to advertise its
existence in the doc, you must fix the device tree.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com