[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250903200822.GO4067720@noisy.programming.kicks-ass.net>
Date: Wed, 3 Sep 2025 22:08:22 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Tejun Heo <tj@...nel.org>
Cc: Andrea Righi <arighi@...dia.com>, Ingo Molnar <mingo@...hat.com>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Valentin Schneider <vschneid@...hat.com>,
Joel Fernandes <joelagnelf@...dia.com>,
David Vernet <void@...ifault.com>,
Changwoo Min <changwoo@...lia.com>, Shuah Khan <shuah@...nel.org>,
sched-ext@...ts.linux.dev, bpf@...r.kernel.org,
linux-kernel@...r.kernel.org,
Luigi De Matteis <ldematteis123@...il.com>
Subject: Re: [PATCH 07/16] sched_ext: Add a DL server for sched_ext tasks
On Wed, Sep 03, 2025 at 09:54:58AM -1000, Tejun Heo wrote:
> Hello,
>
> On Wed, Sep 03, 2025 at 11:33:33AM +0200, Andrea Righi wrote:
> > +static struct task_struct *ext_server_pick_task(struct sched_dl_entity *dl_se,
> > + void *flags)
> > +{
> > + struct rq_flags *rf = flags;
> > +
> > + balance_scx(dl_se->rq, dl_se->rq->curr, rf);
> > + return pick_task_scx(dl_se->rq, rf);
> > +}
>
> I'm a bit confused. This series doesn't have prep patches to add @rf to
> dl_server_pick_f. Is this the right patch?
Patch 14 seems to be the proposed alternative, and I'm not liking that
at all.
That rf passing was very much also needed for that other issue; I'm not
sure why that's gone away.
Powered by blists - more mailing lists