[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250903204258.GB2663015-robh@kernel.org>
Date: Wed, 3 Sep 2025 15:42:58 -0500
From: Rob Herring <robh@...nel.org>
To: Dragan Simic <dsimic@...jaro.org>
Cc: Sarthak Garg <quic_sartgarg@...cinc.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, linux-mmc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, quic_nguyenb@...cinc.com,
quic_rampraka@...cinc.com, quic_pragalla@...cinc.com,
quic_sayalil@...cinc.com, quic_nitirawa@...cinc.com,
quic_bhaskarv@...cinc.com, kernel@....qualcomm.com
Subject: Re: [PATCH V5 0/4] Add level shifter support for qualcomm SOC's
On Wed, Sep 03, 2025 at 10:24:55AM +0200, Dragan Simic wrote:
> Hello Sarthak and Krzysztof,
>
> On 2025-09-03 10:04, Sarthak Garg wrote:
> > Add level shifter support for qualcomm SOC's.
> >
> > - Changed from v4
> > - As suggested by Krzysztof Kozlowski Renamed the property from
> > `max-sd-hs-frequency` to `max-sd-hs-hz` for clarity.
>
> I just spotted this series, so I'm sorry for jumping in late. To me,
> "max-sd-hs-frequency" was actually a better choice, because it goes
> together with the already existing "max-frequency" property.
>
> Yes, "max-sd-hs-hz" is obviously more clear, but to me, consistency
> is more important. Just my $.02.
It's about defining the property units as 'frequency' could be kHz, MHz,
etc. Unfortunately 'max-frequency' existed before standardizing with
units.
Rob
Powered by blists - more mailing lists