[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <40798d54-fb25-45b1-80c8-b378adb545d9@carnegierobotics.com>
Date: Wed, 3 Sep 2025 20:46:32 +0000
From: Woody Douglass <wdouglass@...negierobotics.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Mark Brown
<broonie@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Liam Girdwood
<lgirdwood@...il.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v3 2/2] regulator: pf530x: dt-bindings:
nxp,pf530x-regulator
Rob,
Thank you for pointing this out! I will rebase on the latest rc1 and run `make dt_binding_check` before submitting v5!
Thanks again,
Woodrow Douglass
On 9/3/25 16:33, Rob Herring (Arm) wrote:
>
> On Wed, 03 Sep 2025 11:31:38 -0400, Woodrow Douglass wrote:
>> Bindings for the pf530x series of voltage regulators
>>
>> Signed-off-by: Woodrow Douglass <wdouglass@...negierobotics.com>
>> ---
>> .../devicetree/bindings/regulator/nxp,pf5300.yaml | 52 ++++++++++++++++++++++
>> 1 file changed, 52 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.yaml: properties: 'additionalProperties' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'}
> hint: A json-schema keyword was found instead of a DT property name.
> from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
> $id: http://devicetree.org/schemas/regulator/nxp,pf530x-regulator.yaml
> file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.example.dtb: regulator@28 (nxp,pf5302): 'regulator-always-on', 'regulator-boot-on', 'regulator-max-microvolt', 'regulator-min-microvolt' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/regulator/nxp,pf530x-regulator.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/nxp,pf5300.example.dtb: regulator@28 (nxp,pf5302): 'regulators' is a required property
> from schema $id: http://devicetree.org/schemas/regulator/nxp,pf530x-regulator.yaml#
>
> doc reference errors (make refcheckdocs):
> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/regulator/nxp,pf530x-regulator.yaml
> MAINTAINERS: Documentation/devicetree/bindings/regulator/nxp,pf530x-regulator.yaml
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250902-pf530x-v3-2-4242e7687761@carnegierobotics.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
>
Powered by blists - more mailing lists