linux-kernel - Re: [PATCH v3 3/3] ARM: dts: aspeed: harma: add mp5990

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a65d568540e9ca43d3bfc24cfe5f72d2bb12b3b.camel@codeconstruct.com.au>
Date: Wed, 03 Sep 2025 14:01:22 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Peter Yin <peteryin.openbmc@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] ARM: dts: aspeed: harma: add mp5990

Hi Peter,

On Thu, 2025-08-28 at 15:49 +0800, Peter Yin wrote:
> Add support for the HSC MP5990 device on the Harma platform.
> 
> This change updates the device tree to include the MP5990 HSC
> (Hot Swap Controller), allowing proper configuration and integration
> with the platform.
> 
> Signed-off-by: Peter Yin <peteryin.openbmc@...il.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> index 81278a7702de..23eaf47a38e8 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> @@ -520,6 +520,10 @@ imux28: i2c@0 {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         reg = <0>;
> +                       power-sensor@20 {
> +                               compatible = "mps,mp5990";
> +                               reg = <0x20>;
> +                       };
>                         power-monitor@61 {
>                                 compatible = "isil,isl69260";
>                                 reg = <0x61>;

I've applied the series, however, can you please send a follow-up patch
adding new-lines between the child nodes of imux28? It's not consistent
with the rest of the devicetree and is a bit dense.

Thanks,

Andrew