linux-kernel - Re: [PATCH net-next v4 1/2] tcp: Destroy TCP-AO, TCP-MD5 keys in .sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGrbwDRXcVM08a2=Vph1Bf4uq7+aFe7kBhzs+oA6zRTd8ZXeRA@mail.gmail.com>
Date: Thu, 4 Sep 2025 00:25:50 +0100
From: Dmitry Safonov <dima@...sta.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, 
	"David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Bob Gilligan <gilligan@...sta.com>, Salam Noureddine <noureddine@...sta.com>, 
	Dmitry Safonov <0x7f454c46@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 1/2] tcp: Destroy TCP-AO, TCP-MD5 keys in .sk_destruct()

On Wed, Sep 3, 2025 at 10:18 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> On Wed, Sep 3, 2025 at 1:30 PM Dmitry Safonov via B4 Relay
> <devnull+dima.arista.com@...nel.org> wrote:
[..]
> > +void tcp_md5_destruct_sock(struct sock *sk)
> > +{
> > +       struct tcp_sock *tp = tcp_sk(sk);
> > +
> > +       if (tp->md5sig_info) {
> > +               struct tcp_md5sig_info *md5sig;
> > +
> > +               md5sig = rcu_dereference_protected(tp->md5sig_info, 1);
> > +               tcp_clear_md5_list(sk);
> > +               rcu_assign_pointer(tp->md5sig_info, NULL);
> > +               call_rcu(&md5sig->rcu, tcp_md5sig_info_free_rcu);
> > +       }
> > +}
> > +EXPORT_SYMBOL_GPL(tcp_md5_destruct_sock);
>
> EXPORT_IPV6_MOD_GPL() is preferable.

Thanks, will use that in v5. I did remember that ipv6 may be compiled
as a module, but forgotten that there is a special helper.

>
> Other than that
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>
>
> Thanks!

Thanks,
            Dmitry