linux-kernel - Re: [PATCH bpf-next v3 0/3] selftests/bpf: benchmark all symbols for kprobe-multi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZVTr26Uogf8uh=7HmgG6Qo_uVy3fX8bQgC+Xs63wZcCA@mail.gmail.com>
Date: Wed, 3 Sep 2025 16:50:00 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: andrii@...nel.org, olsajiri@...il.com, eddyz87@...il.com, mykolal@...com, 
	ast@...nel.org, daniel@...earbox.net, martin.lau@...ux.dev, song@...nel.org, 
	yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org, 
	sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, shuah@...nel.org, 
	yikai.lin@...o.com, memxor@...il.com, bpf@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v3 0/3] selftests/bpf: benchmark all symbols for kprobe-multi

On Sun, Aug 31, 2025 at 8:43 PM Menglong Dong <menglong8.dong@...il.com> wrote:
>
> Add the benchmark testcase "kprobe-multi-all", which will hook all the
> kernel functions during the testing.
>
> This series is separated out from [1].
>
> Changes since V2:
> * add some comment to attach_ksyms_all, which notes that don't run the
>   testing on a debug kernel
>
> Changes since V1:
> * introduce trace_blacklist instead of copy-pasting strcmp in the 2nd
>   patch
> * use fprintf() instead of printf() in 3rd patch
>
> Link: https://lore.kernel.org/bpf/20250817024607.296117-1-dongml2@chinatelecom.cn/ [1]
> Menglong Dong (3):
>   selftests/bpf: move get_ksyms and get_addrs to trace_helpers.c
>   selftests/bpf: skip recursive functions for kprobe_multi
>   selftests/bpf: add benchmark testing for kprobe-multi-all
>

this doesn't apply cleanly over bpf-next, can you please rebase and
resend to let CI run?

>  tools/testing/selftests/bpf/bench.c           |   4 +
>  .../selftests/bpf/benchs/bench_trigger.c      |  61 +++++
>  .../selftests/bpf/benchs/run_bench_trigger.sh |   4 +-
>  .../bpf/prog_tests/kprobe_multi_test.c        | 220 +---------------
>  .../selftests/bpf/progs/trigger_bench.c       |  12 +
>  tools/testing/selftests/bpf/trace_helpers.c   | 234 ++++++++++++++++++
>  tools/testing/selftests/bpf/trace_helpers.h   |   3 +
>  7 files changed, 319 insertions(+), 219 deletions(-)
>
> --
> 2.51.0
>