linux-kernel - Re: [PATCHv2 net-next 2/2] net: lan966x: convert fwnode to of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250903165509.6617e812@kernel.org>
Date: Wed, 3 Sep 2025 16:55:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Horatiu Vultur <horatiu.vultur@...rochip.com>,
 UNGLinuxDriver@...rochip.com (maintainer:MICROCHIP LAN966X ETHERNET
 DRIVER), Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>
 (maintainer:SFF/SFP/SFP+ MODULE
 SUPPORT:Keyword:phylink\.h|struct\s+phylink|\.phylink|>,
 linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCHv2 net-next 2/2] net: lan966x: convert fwnode to of

On Mon,  1 Sep 2025 13:20:01 -0700 Rosen Penev wrote:
> This is a purely OF driver. There's no need for fwnode to handle any of
> this, with the exception being phylik_create. Use of_fwnode_handle for
> that.

Not sure this is worth cleaning up, but I'm not an OF API expert.
It's pretty odd that you're sneaking in an extra error check in
such a cleanup patch without even mentioning it.
-- 
pw-bot: cr