linux-kernel - Re: [PATCH 3/4] reset: th1520: Support reset controllers in more subsystems

Open Source and information security mailing list archives

Message-ID: <aLePaQSMLgiGsbf_@pie>
Date: Wed, 3 Sep 2025 00:44:25 +0000
From: Yao Zi <ziyao@...root.org>
To: Maud Spierings <maud_spierings@...mail.com>
Cc: robh@...nel.org, devicetree@...r.kernel.org, conor+dt@...nel.org,
	aou@...s.berkeley.edu, alex@...ti.fr, fustini@...nel.org,
	gaohan@...as.ac.cn, rabenda.cn@...il.com,
	linux-kernel@...r.kernel.org, palmer@...belt.com, guoren@...nel.org,
	p.zabel@...gutronix.de, paul.walmsley@...ive.com,
	m.wilczynski@...sung.com, krzk+dt@...nel.org,
	linux-riscv@...ts.infradead.org, wefu@...hat.com
Subject: Re: [PATCH 3/4] reset: th1520: Support reset controllers in more
 subsystems

On Tue, Sep 02, 2025 at 04:15:08PM +0200, Maud Spierings wrote:
> Hi Yao,
> 
> > Introduce reset controllers for AP, MISC, VI, VP and DSP subsystems and
> > add their reset signal mappings.
> > 
> > Signed-off-by: Yao Zi <ziyao@...root.org>
> > ---
> 
> /* snip */
> 
> >  static const struct of_device_id th1520_reset_match[] = {
> > +	{ .compatible = "thead,th1520-reset-ap", .data = &th1520_ap_reset_data },
> > +	{ .compatible = "thead,th1520-reset-misc", .data = &th1520_misc_reset_data },
> > +	{ .compatible = "thead,th1520-reset-vi", .data = &th1520_vi_reset_data },
> >  	{ .compatible = "thead,th1520-reset", .data = &th1520_reset_data },
> > +	{ .compatible = "thead,th1520-reset-vp", .data = &th1520_vp_reset_data },
> > +	{ .compatible = "thead,th1520-reset-dsp", .data = &th1520_dsp_reset_data },
> 
> I believe these should be alphabetically sorted on compatible name.

This is sorted according to the order they appear in the TRM, but yeah
sorting them alphabetically makes more sense. I'll do this in v2.

Thanks,
Yao Zi

> >  	{ /* sentinel */ }
> >  };
> >  MODULE_DEVICE_TABLE(of, th1520_reset_match);
> > -- 
> > 2.50.1
> 
> Kind regards,
> Maud
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives