linux-kernel - Re: [PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y0qwys30.wl-maz@kernel.org>
Date: Wed, 03 Sep 2025 07:21:07 +0100
From: Marc Zyngier <maz@...nel.org>
To: Zenghui Yu <yuzenghui@...wei.com>
Cc: <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	<lpieralisi@...nel.org>,
	<tglx@...utronix.de>,
	<wanghaibin.wang@...wei.com>
Subject: Re: [PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation

On Wed, 03 Sep 2025 03:33:19 +0100,
Zenghui Yu <yuzenghui@...wei.com> wrote:
> 
> An ITS cache invalidation has been performed immediately after programming
> the L2 DTE in gicv5_its_device_register(). No need to perform it again
> right after a successful gicv5_its_device_register().

Indeed. And this call doesn't check it's been successful either.

> 
> Remove it.
> 
> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
> ---
>  drivers/irqchip/irq-gic-v5-its.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> index 2fb58d76f521..554485f0be1f 100644
> --- a/drivers/irqchip/irq-gic-v5-its.c
> +++ b/drivers/irqchip/irq-gic-v5-its.c
> @@ -768,8 +768,6 @@ static struct gicv5_its_dev *gicv5_its_alloc_device(struct gicv5_its_chip_data *
>  		goto out_dev_free;
>  	}
>  
> -	gicv5_its_device_cache_inv(its, its_dev);
> -
>  	its_dev->its_node = its;
>  
>  	its_dev->event_map = (unsigned long *)bitmap_zalloc(its_dev->num_events, GFP_KERNEL);

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Jazz isn't dead. It just smells funny.