linux-kernel - Re: [PATCH v3 2/3] cpufreq: powernow: Use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6492c8cd-715f-4fad-8286-ffc1b4ea930c@vivo.com>
Date: Wed, 3 Sep 2025 14:50:36 +0800
From: Qianfeng Rong <rongqianfeng@...o.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
 "open list:CPU FREQUENCY SCALING FRAMEWORK" <linux-pm@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] cpufreq: powernow: Use int type to store negative
 error codes

在 2025/9/3 12:14, Viresh Kumar 写道:
> $Subject is incorrect.
>
> On 02-09-25, 19:45, Qianfeng Rong wrote:
>> In powernow_decode_bios(), the 'ret' variable stores either negative error
>> codes or zero returned by get_ranges(), so it needs to be changed to int
>> type.
> You don't need to mention this now. You are making a different change.

Okay, since this patch is no longer part of this series, I will send a
patch for thismodification separately later, thank you.

>
>> However, since the 'ret' variable is only used once and can be
>> simplified to 'return get_ranges()', it is better to remove the 'ret'
>> variable.
>>
>> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
>>   drivers/cpufreq/powernow-k7.c | 4 +---
> There should be a `---` line in between these two statements, you have
> corrupted your patch somehow.
>
Ah this is my bad.