[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DCIZ79KKSSF1.25NJT5ZWR3OOS@nvidia.com>
Date: Wed, 03 Sep 2025 16:10:38 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Danilo Krummrich" <dakr@...nel.org>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
<alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
<gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
"Trevor Gross" <tmgross@...ch.edu>, "David Airlie" <airlied@...il.com>,
"Simona Vetter" <simona@...ll.ch>, "Maarten Lankhorst"
<maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
"Thomas Zimmermann" <tzimmermann@...e.de>, "John Hubbard"
<jhubbard@...dia.com>, "Alistair Popple" <apopple@...dia.com>, "Joel
Fernandes" <joelagnelf@...dia.com>, "Timur Tabi" <ttabi@...dia.com>,
<rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<nouveau@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v3 02/11] gpu: nova-core: move GSP boot code out of
`Gpu` constructor
On Wed Sep 3, 2025 at 8:12 AM JST, Danilo Krummrich wrote:
> On 9/2/25 4:31 PM, Alexandre Courbot wrote:
>> pub(crate) fn new(
>> pdev: &pci::Device<device::Bound>,
>> devres_bar: Arc<Devres<Bar0>>,
>
> The diff is hiding it, but with this patch we should also make sure that this
> returns impl PinInit<Self, Error> rather than Result<impl PinInit<Self>.
>
> I think this should be possible now.
There is still code that can return errors (falcon creation, etc) - do
you mean that we should move it into the pin initializer and turn it
into a `try_pin_init`?
Powered by blists - more mailing lists