linux-kernel - Re: [PATCH net-next v2 1/8] dt-bindings: net: ti,rpmsg-eth: Add DT binding for RPMSG ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250903-dark-horse-of-storm-cf68ea@kuoka>
Date: Wed, 3 Sep 2025 09:18:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: MD Danish Anwar <danishanwar@...com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>, 
	Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, Nishanth Menon <nm@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, Mengyuan Lou <mengyuanlou@...-swift.com>, 
	Xin Guo <guoxin09@...wei.com>, Lei Wei <quic_leiwei@...cinc.com>, Lee Trager <lee@...ger.us>, 
	Michael Ellerman <mpe@...erman.id.au>, Fan Gong <gongfan1@...wei.com>, 
	Lorenzo Bianconi <lorenzo@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Lukas Bulwahn <lukas.bulwahn@...hat.com>, Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>, 
	Suman Anna <s-anna@...com>, Tero Kristo <kristo@...nel.org>, netdev@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org, 
	linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, srk@...com, 
	Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH net-next v2 1/8] dt-bindings: net: ti,rpmsg-eth: Add DT
 binding for RPMSG ETH

On Tue, Sep 02, 2025 at 02:37:39PM +0530, MD Danish Anwar wrote:
> Add device tree binding documentation for Texas Instruments RPMsg Ethernet
> channels. This binding describes the shared memory communication interface
> between host processor and a remote processor for Ethernet packet exchange.
> 
> The binding defines the required 'memory-region' property that references
> the dedicated shared memory area used for exchanging Ethernet packets
> between processors.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---
>  .../devicetree/bindings/net/ti,rpmsg-eth.yaml | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/ti,rpmsg-eth.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,rpmsg-eth.yaml b/Documentation/devicetree/bindings/net/ti,rpmsg-eth.yaml
> new file mode 100644
> index 000000000000..1c86d5c020b0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ti,rpmsg-eth.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ti,rpmsg-eth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments RPMsg channel nodes for Ethernet communication
> +
> +description: |
> +  RPMsg Ethernet subnode represents the communication interface between host
> +  processor and a remote processor.
> +
> +maintainers:
> +  - MD Danish Anwar <danishanwar@...com>
> +
> +properties:
> +  memory-region:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: |
> +      Phandle to the shared memory region used for communication between the
> +      host processor and the remote processor.
> +      This shared memory region is used to exchange Ethernet packets.
> +
> +required:
> +  - memory-region
> +
> +additionalProperties: false

This cannot be really tested and is pointless binding... Really, one
property does not make it a device node.


> +
> +examples:
> +  - |
> +    main_r5fss0_core0 {
> +        mboxes = <&mailbox0_cluster2 &mbox_main_r5fss0_core0>;
> +        memory-region = <&main_r5fss0_core0_dma_memory_region>,
> +                        <&main_r5fss0_core0_memory_region>;

All this is irrelevant, drop.

> +        rpmsg-eth {
> +            memory-region = <&main_r5fss0_core0_memory_region_shm>;
> +        };
> +    };
> -- 
> 2.34.1
>