linux-kernel - Re: [PATCH v3 2/2] KVM: s390: Fix FOLL_*/FAULT_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DCI7DI3ER63H.38SU2KS4NW8R8@linux.ibm.com>
Date: Tue, 02 Sep 2025 11:22:16 +0200
From: "Christoph Schlameuss" <schlameuss@...ux.ibm.com>
To: "Claudio Imbrenda" <imbrenda@...ux.ibm.com>,
        <linux-kernel@...r.kernel.org>
Cc: <linux-s390@...r.kernel.org>, <kvm@...r.kernel.org>, <david@...hat.com>,
        <frankja@...ux.ibm.com>, <seiden@...ux.ibm.com>, <nsg@...ux.ibm.com>,
        <nrb@...ux.ibm.com>, <hca@...ux.ibm.com>, <mhartmay@...ux.ibm.com>,
        <borntraeger@...ibm.com>
Subject: Re: [PATCH v3 2/2] KVM: s390: Fix FOLL_*/FAULT_FLAG_* confusion

On Mon Aug 25, 2025 at 5:18 PM CEST, Claudio Imbrenda wrote:
> Pass the right type of flag to vcpu_dat_fault_handler(); it expects a
> FOLL_* flag (in particular FOLL_WRITE), but FAULT_FLAG_WRITE is passed
> instead.
>
> This still works because they happen to have the same integer value,
> but it's a mistake, thus the fix.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Fixes: 05066cafa925 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
> Acked-by: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Reviewed-by: David Hildenbrand <david@...hat.com>
> Reviewed-by: Steffen Eiden <seiden@...ux.ibm.com>

Reviewed-by: Christoph Schlameuß <schlameuss@...ibm.com>

> ---
>  arch/s390/kvm/kvm-s390.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)