[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <010e24eb-953e-4d0a-845c-ba899b343e9a@lunn.ch>
Date: Wed, 3 Sep 2025 03:14:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Hauke Mehrtens <hauke@...ke-m.de>, Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Andreas Schirm <andreas.schirm@...mens.com>,
Lukas Stockmann <lukas.stockmann@...mens.com>,
Alexander Sverdlin <alexander.sverdlin@...mens.com>,
Peter Christen <peter.christen@...mens.com>,
Avinash Jayaraman <ajayaraman@...linear.com>,
Bing tao Xu <bxu@...linear.com>, Liang Xu <lxu@...linear.com>,
Juraj Povazanec <jpovazanec@...linear.com>,
"Fanni (Fang-Yi) Chan" <fchan@...linear.com>,
"Benny (Ying-Tsan) Weng" <yweng@...linear.com>,
"Livia M. Rosu" <lrosu@...linear.com>,
John Crispin <john@...ozen.org>
Subject: Re: [RFC PATCH net-next 1/6] net: dsa: lantiq_gswip: convert
accessors to use regmap
> + if (ret) {
> + WARN_ON_ONCE(1);
WARN_ON_ONCE() returns the evaluation. So you can make this:
> + if (WARN_ON_ONCE(ret) {
> + dev_err(priv->dev, "failed to read switch register\n");
> + return 0;
I personally think this looks better than having the (1).
Andrew
Powered by blists - more mailing lists