linux-kernel - Re: [PATCH] gfs2, udf: update to use mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509031521.aEPzyTZp-lkp@intel.com>
Date: Wed, 3 Sep 2025 16:13:42 +0800
From: kernel test robot <lkp@...el.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Christian Brauner <christian@...uner.io>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Andreas Gruenbacher <agruenba@...hat.com>, Jan Kara <jack@...e.com>,
	gfs2@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gfs2, udf: update to use mmap_prepare

Hi Lorenzo,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on gfs2/for-next linus/master v6.17-rc4 next-20250902]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Stoakes/gfs2-udf-update-to-use-mmap_prepare/20250902-200024
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20250902115341.292100-1-lorenzo.stoakes%40oracle.com
patch subject: [PATCH] gfs2, udf: update to use mmap_prepare
config: x86_64-randconfig-005-20250903 (https://download.01.org/0day-ci/archive/20250903/202509031521.aEPzyTZp-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250903/202509031521.aEPzyTZp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509031521.aEPzyTZp-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/gfs2/file.c:1582:18: error: use of undeclared identifier 'gfs2_mmap'; did you mean 'vfs_mmap'?
    1582 |         .mmap_prepare   = gfs2_mmap,
         |                           ^~~~~~~~~
         |                           vfs_mmap
   include/linux/fs.h:2393:19: note: 'vfs_mmap' declared here
    2393 | static inline int vfs_mmap(struct file *file, struct vm_area_struct *vma)
         |                   ^
>> fs/gfs2/file.c:1582:18: error: incompatible function pointer types initializing 'int (*)(struct vm_area_desc *)' with an expression of type 'int (struct file *, struct vm_area_struct *)' [-Wincompatible-function-pointer-types]
    1582 |         .mmap_prepare   = gfs2_mmap,
         |                           ^~~~~~~~~
   2 errors generated.


vim +1582 fs/gfs2/file.c

  1574	
  1575	const struct file_operations gfs2_file_fops = {
  1576		.llseek		= gfs2_llseek,
  1577		.read_iter	= gfs2_file_read_iter,
  1578		.write_iter	= gfs2_file_write_iter,
  1579		.iopoll		= iocb_bio_iopoll,
  1580		.unlocked_ioctl	= gfs2_ioctl,
  1581		.compat_ioctl	= gfs2_compat_ioctl,
> 1582		.mmap_prepare	= gfs2_mmap,
  1583		.open		= gfs2_open,
  1584		.release	= gfs2_release,
  1585		.fsync		= gfs2_fsync,
  1586		.lock		= gfs2_lock,
  1587		.flock		= gfs2_flock,
  1588		.splice_read	= copy_splice_read,
  1589		.splice_write	= gfs2_file_splice_write,
  1590		.setlease	= simple_nosetlease,
  1591		.fallocate	= gfs2_fallocate,
  1592		.fop_flags	= FOP_ASYNC_LOCK,
  1593	};
  1594	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki