| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250903-canxl-netlink-prep-v1-7-904bd6037cd9@kernel.org> Date: Wed, 03 Sep 2025 17:50:06 +0900 From: Vincent Mailhol <mailhol@...nel.org> To: Marc Kleine-Budde <mkl@...gutronix.de>, Oliver Hartkopp <socketcan@...tkopp.net> Cc: Vincent Mailhol <mailhol@...nel.org>, Stéphane Grosjean <stephane.grosjean@...-networks.com>, Robert Nawrath <mbro1689@...il.com>, Minh Le <minh.le.aj@...esas.com>, Duy Nguyen <duy.nguyen.rh@...esas.com>, linux-can@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 07/21] can: netlink: remove comment in can_validate() The comment in can_validate() is just paraphrasing the code. When adding CAN XL, updating this comment would add some overhead work for no clear benefit. Now that the function has been refactored and split into smaller pieces, let the code speak for itself. Remove the comment. Signed-off-by: Vincent Mailhol <mailhol@...nel.org> --- drivers/net/can/dev/netlink.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/can/dev/netlink.c b/drivers/net/can/dev/netlink.c index f7b12057bc9c6c286aa0c4341d565a497254296d..6ea629331d20483c5e70567eb1be226a3b09882c 100644 --- a/drivers/net/can/dev/netlink.c +++ b/drivers/net/can/dev/netlink.c @@ -143,13 +143,6 @@ static int can_validate(struct nlattr *tb[], struct nlattr *data[], u32 flags = 0; int err; - /* Make sure that valid CAN FD configurations always consist of - * - nominal/arbitration bittiming - * - data bittiming - * - control mode with CAN_CTRLMODE_FD set - * - TDC parameters are coherent (details below) - */ - if (!data) return 0; -- 2.49.1
Powered by blists - more mailing lists