[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aLgLoal9q7Zx7Yto@devbig569.cln6.facebook.com>
Date: Wed, 3 Sep 2025 02:34:25 -0700
From: Yueyang Pan <pyyjason@...il.com>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Suren Baghdasaryan <surenb@...gle.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Michal Hocko <mhocko@...e.com>,
Brendan Jackman <jackmanb@...gle.com>,
Johannes Weiner <hannes@...xchg.org>, Zi Yan <ziy@...dia.com>,
Vishal Moola <vishal.moola@...il.com>,
Shakeel Butt <shakeel.butt@...ux.dev>,
Usama Arif <usamaarif642@...il.com>, linux-mm@...ck.org,
kernel-team@...a.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mm/show_mem: Dump the status of the mem alloc
profiling before printing
On Wed, Sep 03, 2025 at 11:26:01AM +0200, Vlastimil Babka wrote:
> On 9/2/25 17:57, Yueyang Pan wrote:
> > This patch prints the status of the memory allocation profiling
> > before __show_mem actually prints the detailed allocation info.
> > This way will let us know the `0B` we saw in allocation info is
> > because the profiling is disabled or the allocation is actually
> > 0B.
> >
> > Signed-off-by: Yueyang Pan <pyyjason@...il.com>
> > ---
> > mm/show_mem.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/mm/show_mem.c b/mm/show_mem.c
> > index ecf20a93ea54..51892ce2efc4 100644
> > --- a/mm/show_mem.c
> > +++ b/mm/show_mem.c
> > @@ -427,6 +427,8 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
> >
> > nr = alloc_tag_top_users(tags, ARRAY_SIZE(tags), false);
> > if (nr) {
> > + pr_notice("Memory alloction profiling is turned %s\n",
>
> There's a typo "alloction".
Nice catch. Thanks!
>
> > + mem_alloc_profiling_enabled() ? "on" : "off");
> > pr_notice("Memory allocations:\n");
>
> But I think the message would be more obvious if it said e.g.:
>
> "Memory allocations (profiling is currently [on/off]):"
I can change it in the next version. I saw Andrew gave approval. In this case, shall
I send v3 or create a new patch?
>
> > for (i = 0; i < nr; i++) {
> > struct codetag *ct = tags[i].ct;
>
Thanks
Pan
Powered by blists - more mailing lists