linux-kernel - Re: [PATCH v2 5/5] riscv: dts: microchip: add a device tree for Discovery Kit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b371196-c853-4e47-980f-3f2b3525180e@microchip.com>
Date: Wed, 3 Sep 2025 09:43:46 +0000
From: <Valentina.FernandezAlanis@...rochip.com>
To: <ziyao@...root.org>, <Conor.Dooley@...rochip.com>,
	<Daire.McNamara@...rochip.com>, <paul.walmsley@...ive.com>,
	<palmer@...belt.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<aou@...s.berkeley.edu>, <alex@...ti.fr>
CC: <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <Valentina.FernandezAlanis@...rochip.com>
Subject: Re: [PATCH v2 5/5] riscv: dts: microchip: add a device tree for
 Discovery Kit

On 02/09/2025 09:32, Yao Zi wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Tue, Sep 02, 2025 at 08:55:48AM +0100, Valentina Fernandez wrote:
>> Add a minimal device tree for the Microchip PolarFire SoC Discovery Kit.
>> The Discovery Kit is a cost-optimized board based on PolarFire SoC
>> MPFS095T and features:
>>
>> - 1 GB DDR4x16
>> - 1x Gigabit Ethernet
>> - 3x UARTs
>> - Raspberry Pi connector
>> - mikroBus connector
>> - microSD card connector
>>
>> Link: https://www.microchip.com/en-us/development-tool/mpfs-disco-kit
>> Signed-off-by: Valentina Fernandez <valentina.fernandezalanis@...rochip.com>
>> ---
>>   arch/riscv/boot/dts/microchip/Makefile        |   1 +
>>   .../dts/microchip/mpfs-disco-kit-fabric.dtsi  |  58 ++++++
>>   .../boot/dts/microchip/mpfs-disco-kit.dts     | 190 ++++++++++++++++++
>>   3 files changed, 249 insertions(+)
>>   create mode 100644 arch/riscv/boot/dts/microchip/mpfs-disco-kit-fabric.dtsi
>>   create mode 100644 arch/riscv/boot/dts/microchip/mpfs-disco-kit.dts
> 
> ...
> 
>> diff --git a/arch/riscv/boot/dts/microchip/mpfs-disco-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-disco-kit.dts
>> new file mode 100644
>> index 000000000000..c068b9bb5bfd
>> --- /dev/null
>> +++ b/arch/riscv/boot/dts/microchip/mpfs-disco-kit.dts
> 
> ...
> 
>> +&mbox {
>> +     status = "okay";
>> +};
>> +
>> +&mmc {
>> +     bus-width = <4>;
>> +     disable-wp;
>> +     cap-sd-highspeed;
>> +     cap-mmc-highspeed;
>> +     sd-uhs-sdr12;
>> +     sd-uhs-sdr25;
>> +     sd-uhs-sdr50;
>> +     sd-uhs-sdr104;
> 
> I think sd-uhs-sdr104 implies sd-uhs-sdr{12,25,50}, thus the latter
> three properties could be dropped.
Even though the kernel treats sd-uhs-sdr104 as implying support for 
sdr12, sdr25, and sdr50, the binding has no such rules about implying 
other modes. For this reason, I thought it could be valid to explicitly 
list all supported modes to ensure accurate hw representation.>
>> +     no-1-8-v;
>> +     status = "okay";
>> +};
> 
> Best regards,
> Yao Zi