[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAA+D8AOCTqb5jLeRapYk4wRGZrsrPiuAR=ow3OA1B0+M9X4k7w@mail.gmail.com>
Date: Wed, 3 Sep 2025 18:41:05 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Shengjiu Wang <shengjiu.wang@....com>, andrzej.hajda@...el.com,
neil.armstrong@...aro.org, rfoss@...nel.org,
Laurent.pinchart@...asonboard.com, jonas@...boo.se, jernej.skrabec@...il.com,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
airlied@...il.com, simona@...ll.ch, lumag@...nel.org, dianders@...omium.org,
cristian.ciocaltea@...labora.com, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, victor.liu@....com, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, p.zabel@...gutronix.de,
devicetree@...r.kernel.org, l.stach@...gutronix.de, perex@...ex.cz,
tiwai@...e.com, linux-sound@...r.kernel.org
Subject: Re: [PATCH v5 4/7] drm/bridge: dw-hdmi: Add API dw_hdmi_set_sample_iec958()
for iec958 format
On Tue, Sep 2, 2025 at 12:52 AM Luca Ceresoli <luca.ceresoli@...tlin.com> wrote:
>
> Hello Shengjiu,
>
> On Thu, 21 Aug 2025 15:31:28 +0800
> Shengjiu Wang <shengjiu.wang@....com> wrote:
>
> > Add API dw_hdmi_set_sample_iec958() for IEC958 format because audio device
> > driver needs IEC958 information to configure this specific setting.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > Acked-by: Liu Ying <victor.liu@....com>
>
> [...]
>
> > +void dw_hdmi_set_sample_iec958(struct dw_hdmi *hdmi, unsigned int iec958)
> > +{
> > + mutex_lock(&hdmi->audio_mutex);
> > + hdmi->sample_iec958 = iec958;
> > + mutex_unlock(&hdmi->audio_mutex);
> > +}
>
> Apologies for jumping in the discussion as late as in v5, but I noticed
> this patch and I was wondering whether this mutex_lock/unlock() is
> really needed, as you're copying an int.
Thanks for your comments.
Seems it is not necessary to add mutex here. I just follow the code as
other similar functions. I will send a new version to update it.
Best regards
Shengjiu Wang
Shengjiu Wang
>
> Luca
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Powered by blists - more mailing lists