linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8183: Fix out of range pull values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJaC47zFY7zvTVFum9oMiV87dgo49a9e3HW1T5_vQtAzA@mail.gmail.com>
Date: Tue, 2 Sep 2025 20:50:50 -0500
From: Rob Herring <robh@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, Enric Balletbo i Serra <eballetbo@...nel.org>, 
	Ben Ho <Ben.Ho@...iatek.com>, Fabien Parent <fparent@...libre.com>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: Fix out of range pull values

On Wed, Jul 23, 2025 at 3:16 AM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> Il 22/07/25 19:11, Rob Herring (Arm) ha scritto:
> > A value of 10 is not valid for "mediatek,pull-down-adv" and
> > "mediatek,pull-up-adv" properties which have defined values of 0-3. It
> > appears the "10" was written as a binary value. The driver only looks at
> > the lowest 2 bits, so the value "10" decimal works out the same as if
> > "2" was used.
> >
> > Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
> > Fixes: 19b6403f1e2a ("arm64: dts: mt8183: add mt8183 pumpkin board")
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> > This is just a few of the warnings related to mt8183-pinctrl... Mediatek
> > is #1 for DT warnings on arm64. And by #1, I mean worst. :( It would be
> > nice to see some progress on fixing them. Otherwise, seeing new Mediatek
> > bindings rather than fixing the existing stuff makes me grumpy.
> >
>
> Thanks for this fix.
>
> You're absolutely right about this, let me check what I can do (and if I can get
> some colleague(s) of mine to look at that while I'm away in August).
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Is this going to get applied and into linux-next sometime soon? Only
been like 6 weeks...

Rob