linux-kernel - Re: [PATCH 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLgmKxPEAduajodW@smile.fi.intel.com>
Date: Wed, 3 Sep 2025 14:27:39 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Nuno Sá <noname.nuno@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Michael Walle <mwalle@...nel.org>,
	Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Marcelo Schmitt <marcelo.schmitt@...log.com>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>,
	Tobias Sperling <tobias.sperling@...ting.com>,
	Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Trevor Gamblin <tgamblin@...libre.com>,
	Esteban Blanc <eblanc@...libre.com>,
	Ramona Alexandra Nechita <ramona.nechita@...log.com>,
	Thomas Bonnefille <thomas.bonnefille@...tlin.com>,
	Hans de Goede <hansg@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO

On Wed, Sep 03, 2025 at 12:02:56PM +0100, Nuno Sá wrote:
> On Wed, 2025-09-03 at 08:47 +0200, Linus Walleij wrote:
> > On Wed, Sep 3, 2025 at 7:23 AM Matti Vaittinen <mazziesaccount@...il.com>
> > wrote:

...

> > > Anyways, fast-forward to this day, I don't see it handling valid_mask. I
> > > think it is a must for this device/driver, where pins can be either
> > > GPIOs or ADC inputs.
> > 
> > Why not just add a .init_valid_mask() to
> > struct gpio_regmap_config so it can just pass that
> > down to its gpio_chip?
> 
> Hmm I guess I'll get a similar comment on the series I just sent [1] :)

Right, you have the mask but you don't use gpio-regmap!

> [1]: https://lore.kernel.org/linux-hwmon/20250903-ltc4283-support-v2-0-6bce091510bf@analog.com/

-- 
With Best Regards,
Andy Shevchenko