linux-kernel - Re: [PATCH][next] drm/sysfb: Remove double assignment to pointer crtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be9eb10f-f69e-47fa-a2a3-64c14ed0c9d8@suse.de>
Date: Wed, 3 Sep 2025 13:28:24 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Colin Ian King <colin.i.king@...il.com>,
 Javier Martinez Canillas <javierm@...hat.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, dri-devel@...ts.freedesktop.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/sysfb: Remove double assignment to pointer
 crtc_state

Hi

Am 03.09.25 um 10:31 schrieb Colin Ian King:
> The declaration of pointer crtc_state includes an assignment to
> crtc_state. The double assignment of crtc_state is redundant and
> can be removed.
>
> Fixes: 061963cd9e5b ("drm/sysfb: Blit to CRTC destination format")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Thanks a lot. I'll merged the patch in the drm-misc.

Best regards
Thomas

> ---
>   drivers/gpu/drm/sysfb/drm_sysfb_modeset.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c b/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c
> index 963c380fea64..ddb4a7523ee6 100644
> --- a/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c
> +++ b/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c
> @@ -238,8 +238,7 @@ void drm_sysfb_plane_helper_atomic_update(struct drm_plane *plane, struct drm_at
>   	struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(plane_state);
>   	struct drm_framebuffer *fb = plane_state->fb;
>   	unsigned int dst_pitch = sysfb->fb_pitch;
> -	struct drm_crtc_state *crtc_state = crtc_state =
> -		drm_atomic_get_new_crtc_state(state, plane_state->crtc);
> +	struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, plane_state->crtc);
>   	struct drm_sysfb_crtc_state *sysfb_crtc_state = to_drm_sysfb_crtc_state(crtc_state);
>   	const struct drm_format_info *dst_format = sysfb_crtc_state->format;
>   	struct drm_atomic_helper_damage_iter iter;

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)