linux-kernel - Re: [PATCH v2 8/9] leds: mc13783: use fsl,led-control as node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250903115925.GM2163762@google.com>
Date: Wed, 3 Sep 2025 12:59:25 +0100
From: Lee Jones <lee@...nel.org>
To: Alexander Kurz <akurz@...la.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Dzmitry Sankouski <dsankouski@...il.com>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	devicetree@...r.kernel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 8/9] leds: mc13783: use fsl,led-control as node name

Did you actually test this?

> According to fsl,mc13xxx.yaml, the node name for led-control is
> vendor prefixed. Change it accordingly.

According to what, now?  I see:

% find . -name fsl,mc13xxx.yaml
<no results>

% git grep fsl,led-control
<no results>

% git grep led-control | grep -v led-controller
Documentation/devicetree/bindings/mfd/mc13xxx.txt:  "led-control". Number of register depends of used IC, for MC13783 is 6,
Documentation/devicetree/bindings/mfd/mc13xxx.txt:			led-control = <0x000 0x000 0x0e0 0x000>;
Documentation/netlink/specs/rt-link.yaml:        name: coupled-control
arch/arm/boot/dts/nxp/imx/imx27-phytec-phycore-som.dtsi:			led-control = <0x001 0x000 0x000 0x000 0x000 0x000>;
arch/arm/boot/dts/nxp/imx/imx51-zii-rdu1.dts:			led-control = <0x0 0x0 0x3f83f8 0x0>;
arch/arm/boot/dts/nxp/imx/imx51-zii-scu2-mezz.dts:			led-control = <0x0 0x0 0x3f83f8 0x0>;
arch/arm/boot/dts/nxp/imx/imx51-zii-scu3-esb.dts:			led-control = <0x0 0x0 0x3f83f8 0x0>;
drivers/leds/leds-mc13783.c:	ret = of_property_read_u32_array(parent, "led-control",

> Signed-off-by: Alexander Kurz <akurz@...la.de>
> ---
>  drivers/leds/leds-mc13783.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
> index e22f09d13798..11add1fd24ce 100644
> --- a/drivers/leds/leds-mc13783.c
> +++ b/drivers/leds/leds-mc13783.c
> @@ -127,7 +127,7 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
>  	if (!parent)
>  		return ERR_PTR(-ENODATA);
>  
> -	ret = of_property_read_u32_array(parent, "led-control",
> +	ret = of_property_read_u32_array(parent, "fsl,led-control",
>  					 pdata->led_control,
>  					 leds->devtype->num_regs);

-- 
Lee Jones [李琼斯]