linux-kernel - Re: [PATCH v3 3/3] media: qcom: camss: tpg: Add TPG support for SA8775P and QCS8300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d40c5ab2-2195-462f-9fd4-8c519a43f032@oss.qualcomm.com>
Date: Wed, 3 Sep 2025 14:16:30 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Wenmeng Liu <quic_wenmliu@...cinc.com>, Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 3/3] media: qcom: camss: tpg: Add TPG support for
 SA8775P and QCS8300

On 8/22/25 2:09 PM, Wenmeng Liu wrote:
> Add support for TPG found on SA8775P and QCS8300.
> 
> Signed-off-by: Wenmeng Liu <quic_wenmliu@...cinc.com>
> ---

[...]

> +#define TPG_HW_VERSION		0x0
> +#define		HW_VERSION_STEPPING		0
> +#define		HW_VERSION_REVISION		16
> +#define		HW_VERSION_GENERATION		28

Please use GENMASK for defining bitfields, avoid tabs (just a space
is fine, perhaps add one in front of #define to denote bitfields) and
use FIELD_PREP/FIELD_GET accessors

Konrad