linux-kernel - Re: [PATCH v3 03/14] rust: drm: gem: Drop Object::SIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DEAC44E1-9037-4609-A53F-0BBBDCC576A0@collabora.com>
Date: Thu, 4 Sep 2025 09:17:49 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Lyude Paul <lyude@...hat.com>
Cc: dri-devel@...ts.freedesktop.org,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Danilo Krummrich <dakr@...nel.org>,
 David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>,
 Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Asahi Lina <lina+kernel@...hilina.net>
Subject: Re: [PATCH v3 03/14] rust: drm: gem: Drop Object::SIZE



> On 29 Aug 2025, at 19:35, Lyude Paul <lyude@...hat.com> wrote:
> 
> Drive-by fix, it doesn't seem like anything actually uses this constant
> anymore.
> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Reviewed-by: Danilo Krummrich <dakr@...nel.org>
> ---
> rust/kernel/drm/gem/mod.rs | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs
> index 80940ed11368d..b27b9fbf28bbb 100644
> --- a/rust/kernel/drm/gem/mod.rs
> +++ b/rust/kernel/drm/gem/mod.rs
> @@ -12,7 +12,7 @@
>     prelude::*,
>     types::{ARef, AlwaysRefCounted, Opaque},
> };
> -use core::{mem, ops::Deref, ptr::NonNull};
> +use core::{ops::Deref, ptr::NonNull};
> 
> /// A type alias for retrieving a [`Driver`]s [`DriverFile`] implementation from its
> /// [`DriverObject`] implementation.
> @@ -197,9 +197,6 @@ pub struct Object<T: DriverObject + Send + Sync> {
> }
> 
> impl<T: DriverObject> Object<T> {
> -    /// The size of this object's structure.
> -    pub const SIZE: usize = mem::size_of::<Self>();
> -
>     const OBJECT_FUNCS: bindings::drm_gem_object_funcs = bindings::drm_gem_object_funcs {
>         free: Some(Self::free_callback),
>         open: Some(open_callback::<T>),
> -- 
> 2.50.0
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>