linux-kernel - Re: [PATCH v3 0/3] pinctrl: tegra: Add Tegra186 pinmux driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <czukh3b6lb7x3uwn2khcgzrkccyveokdpksxban7arhod6ygh3@uukoulmn5gil>
Date: Thu, 4 Sep 2025 15:09:21 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Aaron Kling <webgeek1234@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jonathan Hunter <jonathanh@...dia.com>, 
	Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/3] pinctrl: tegra: Add Tegra186 pinmux driver

On Wed, Sep 03, 2025 at 12:58:06PM -0500, Aaron Kling wrote:
> On Wed, Sep 3, 2025 at 1:55 AM Linus Walleij <linus.walleij@...aro.org> wrote:
> >
> > On Wed, Sep 3, 2025 at 6:54 AM Aaron Kling <webgeek1234@...il.com> wrote:
> > > On Tue, Aug 19, 2025 at 6:30 AM Linus Walleij <linus.walleij@...aro.org> wrote:
> > > >
> > > > On Tue, Aug 12, 2025 at 11:24 PM Aaron Kling via B4 Relay
> > > > <devnull+webgeek1234.gmail.com@...nel.org> wrote:
> > > >
> > > > > This series adds support for Tegra186 pin control, based on a downstream
> > > > > driver, updated to match the existing Tegra194 driver.
> > > > >
> > > > > Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> > > > (...)
> > > > > Aaron Kling (3):
> > > > >       dt-bindings: pinctrl: Document Tegra186 pin controllers
> > > > >       pinctrl: tegra: Add Tegra186 pinmux driver
> > > >
> > > > These two applied to the pin control git tree.
> > >
> > > On patch 3, Mikko noted that I accidentally amended the formatting
> > > changes intended for patch 2 into patch 3. Linus, since you've already
> > > picked this up to your tree, is it too late to fix this properly in a
> > > new revision? It doesn't appear to have made it to the main tree yet.
> > > Or do I need to send in a fixup?
> >
> > It's one of the first drivers I merged with plenty of other stuff on top
> > so I can't amend it, just send a fixup based on my "devel" branch
> > (or linux-next, it should work too).
> 
> I am highly confused now. When I went to make the fixup series, the
> fixup didn't apply. Looking at next-20250903 [0], pinctrl-tegra186.c
> looks like I wanted it to, the base commit has all the format fixes.
> Which doesn't match the commit on this series. Which leads me to a
> couple questions:
> 
> 1) Does anyone know what happened? I'm not particularly a fan of not
> knowing why something happened, even if it's beneficial at the time.

Maybe auto-formatting or something else that Linus did?

> 2) What should I do with the dt commit now? Ask the Tegra subsystem
> maintainer to do a manual fixup when pulling? Even without a manual
> fixup, the bad part of the commit would fall out when getting applied
> on top of next.

I can drop the extra hunks when applying, no need to do anything.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)