linux-kernel - Re: [PATCH] drm/amdkfd: Fix error code sign for EINVAL in svm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_N=hQH9OGp2GfdPeOq7V2B_UX0VCDQ-XcTDroy-WHRmyQ@mail.gmail.com>
Date: Thu, 4 Sep 2025 10:07:19 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Felix Kuehling <Felix.Kuehling@....com>, Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Philip Yang <Philip.Yang@....com>, 
	Alex Sierra <alex.sierra@....com>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl()

Applied.  Thanks!

Alex

On Thu, Sep 4, 2025 at 8:54 AM Qianfeng Rong <rongqianfeng@...o.com> wrote:
>
> Use negative error code -EINVAL instead of positive EINVAL in the default
> case of svm_ioctl() to conform to Linux kernel error code conventions.
>
> Fixes: 42de677f7999 ("drm/amdkfd: register svm range")
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 521c14c7a789..68ba239b2e5d 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -4261,7 +4261,7 @@ svm_ioctl(struct kfd_process *p, enum kfd_ioctl_svm_op op, uint64_t start,
>                 r = svm_range_get_attr(p, mm, start, size, nattrs, attrs);
>                 break;
>         default:
> -               r = EINVAL;
> +               r = -EINVAL;
>                 break;
>         }
>
> --
> 2.34.1
>