linux-kernel - Re: [PATCH] mtd: spi-nor: spansion: Modify addr_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mafs03492uwam.fsf@kernel.org>
Date: Thu, 04 Sep 2025 16:28:17 +0200
From: Pratyush Yadav <pratyush@...nel.org>
To: Santhosh Kumar K <s-k6@...com>
Cc: <miquel.raynal@...tlin.com>,  <richard@....at>,  <vigneshr@...com>,
  <tudor.ambarus@...aro.org>,  <pratyush@...nel.org>,  <mwalle@...nel.org>,
  <linux-mtd@...ts.infradead.org>,  <linux-kernel@...r.kernel.org>,
  <praneeth@...com>,  <p-mantena@...com>,  <a-dutta@...com>,
  <u-kumar1@...com>
Subject: Re: [PATCH] mtd: spi-nor: spansion: Modify addr_mode_nbytes for DTR
 mode

On Thu, Sep 04 2025, Santhosh Kumar K wrote:

> The nor->params->addr_mode_nbytes parameter defines the address byte
> count for the current addressing mode. When transitioning between SDR
> and DDR modes, this parameter must be properly updated to maintain the
> correct addressing behavior. So, implement the necessary updates to
> nor->params->addr_mode_nbytes during both DDR mode enablement and
> disablement operations to ensure address byte counts remain consistent
> with the active transfer mode.

Doesn't spi_nor_set_4byte_addr_mode() do this already? What is the
difference here? Are we missing a call to it after
spi_nor_set_octal_dtr() in some path?

Also, do you see a real bug with this or is this purely theoretical?

[...]

-- 
Regards,
Pratyush Yadav