linux-kernel - [PATCH v2 0/2] Add dev_err_probe() to i2c designware platform probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250904-i2c-dw-dev-err-probe-v2-0-e59da34815fa@bootlin.com>
Date: Thu, 04 Sep 2025 16:31:05 +0200
From: Benoît Monin <benoit.monin@...tlin.com>
To: Jarkko Nikula <jarkko.nikula@...ux.intel.com>, 
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
 Mika Westerberg <mika.westerberg@...ux.intel.com>, 
 Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
 Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, 
 Tawfik Bayouk <tawfik.bayouk@...ileye.com>, linux-i2c@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 Benoît Monin <benoit.monin@...tlin.com>
Subject: [PATCH v2 0/2] Add dev_err_probe() to i2c designware platform
 probing

I recently spend some time debugging a case where the i2c controller
never showed up. In the end it was caused by a missing reset controller
due to a typo in the device tree.

While this has nothing to do with the i2c designware driver, not having
any hint about why the device stays in deferred probe state does not
help.

The first patch convert dev_err() to dev_err_probe() on request IRQ
failure, this simplifies error handling.

The second patch add dev_err_probe() in the error paths that can return
-EPROBE_DEFER in dw_i2c_plat_probe() to aid in debugging deferred probe
errors.

Signed-off-by: Benoît Monin <benoit.monin@...tlin.com>
---
Changes in v2:
- Split the patch in two: one to convert dev_err() to dev_err_probe()
  on request IRQ failure and the other adding dev_err_probe() to error
  paths in dw_i2c_plat_probe()
- Link to v1: https://lore.kernel.org/r/20250904-i2c-dw-dev-err-probe-v1-1-acca6ffd122e@bootlin.com

---
Benoît Monin (2):
      i2c: designware: convert to dev_err_probe() on request IRQ error
      i2c: designware: use dev_err_probe() when probing platform device

 drivers/i2c/busses/i2c-designware-master.c  |  9 ++++-----
 drivers/i2c/busses/i2c-designware-platdrv.c | 10 ++++++----
 drivers/i2c/busses/i2c-designware-slave.c   |  9 ++++-----
 3 files changed, 14 insertions(+), 14 deletions(-)
---
base-commit: b320789d6883cc00ac78ce83bccbfe7ed58afcf0
change-id: 20250822-i2c-dw-dev-err-probe-eaf9bce3ef4c

Best regards,
-- 
Benoît Monin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com