linux-kernel - Re: [PATCH] audit: init ab->skb_list earlier in audit_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cde565adc43452e83958fbe0ab54080d@paul-moore.com>
Date: Thu, 04 Sep 2025 11:06:31 -0400
From: Paul Moore <paul@...l-moore.com>
To: Eric Dumazet <edumazet@...gle.com>, Casey Schaufler <casey@...aufler-ca.com>
Cc: linux-kernel <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>, Eric Dumazet <edumazet@...gle.com>, syzbot+bb185b018a51f8d91fd2@...kaller.appspotmail.com, Eric Paris <eparis@...hat.com>, audit@...r.kernel.org
Subject: Re: [PATCH] audit: init ab->skb_list earlier in audit_buffer_alloc()

On Sep  4, 2025 Eric Dumazet <edumazet@...gle.com> wrote:
> 
> syzbot found a bug in audit_buffer_alloc() if nlmsg_new() returns NULL.
> 
> We need to initialize ab->skb_list before calling audit_buffer_free()
> which will use both the skb_list spinlock and list pointers.
> 
> Fixes: eb59d494eebd ("audit: add record for multiple task security contexts")
> Reported-by: syzbot+bb185b018a51f8d91fd2@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/lkml/68b93e3c.a00a0220.eb3d.0000.GAE@google.com/T/#u
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Casey Schaufler <casey@...aufler-ca.com>
> Cc: Paul Moore <paul@...l-moore.com>
> Cc: Eric Paris <eparis@...hat.com>
> Cc: audit@...r.kernel.org
> ---
>  kernel/audit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks Eric, merged into audit/dev.

--
paul-moore.com