[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250904090301.552ef178@kernel.org>
Date: Thu, 4 Sep 2025 09:03:01 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Maksimilijan Marosevic <maksimilijan.marosevic@...ton.me>
Cc: davem@...emloft.net, dsahern@...nel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev,
syzbot+a259a17220263c2d73fc@...kaller.appspotmail.com
Subject: Re: [PATCH 1/1] ipv6: Check AF_UNSPEC in ip6_route_multipath_add()
On Mon, 04 Aug 2025 20:42:53 +0000 Maksimilijan Marosevic wrote:
> This check was removed in commit e6f497955fb6 ("ipv6: Check GATEWAY
> in rtm_to_fib6_multipath_config().") as part of rt6_qualify_for ecmp().
> The author correctly recognises that rt6_qualify_for_ecmp() returns
> false if fb_nh_gw_family is set to AF_UNSPEC, but then mistakes
> AF_UNSPEC for AF_INET6 when reasoning that the check is unnecessary.
> This means certain malformed entries don't get caught in
> ip6_route_multipath_add().
>
> This patch reintroduces the AF_UNSPEC check while respecting changes
> of the initial patch.
Hi Maksimilijan!
Are you planning to repost this with a test?
If not I suppose we can enlist the author of the commit to help with
the selftest..
Powered by blists - more mailing lists