linux-kernel - Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68b9b8fdb0443_70a18294b1@iweiny-mobl.notmuch>
Date: Thu, 4 Sep 2025 11:06:21 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Colin Ian King
	<colin.i.king@...il.com>, Dan Williams <dan.j.williams@...el.com>, Dave Jiang
	<dave.jiang@...el.com>
CC: Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
	Len Brown <lenb@...nel.org>, Jia He <justin.he@....com>,
	<nvdimm@...ts.linux.dev>, <linux-acpi@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being
 reportedin dev_err message

Rafael J. Wysocki wrote:
> On Tue, Sep 2, 2025 at 1:46 PM Colin Ian King <colin.i.king@...il.com> wrote:
> >
> > There appears to be a cut-n-paste error with the incorrect field
> > ndr_desc->numa_node being reported for the target node. Fix this by
> > using ndr_desc->target_node instead.
> >
> > Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> > Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> > ---
> >  drivers/acpi/nfit/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index ae035b93da08..3eb56b77cb6d 100644
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
> >         if (ndr_desc->target_node == NUMA_NO_NODE) {
> >                 ndr_desc->target_node = phys_to_target_node(spa->address);
> >                 dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> > -                       NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> > +                       NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
> >         }
> >
> >         /*
> > --
> 
> Dan, Dave, are you guys going to take this one, or should I take care of it?

Apologies, I should have said I'm taking this one.  It is queued up.

Thanks for the ping,
Ira