linux-kernel - [PATCH] vt: remove redundant check on vc_mode in con_font

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250904023345.13731-1-wangliang74@huawei.com>
Date: Thu, 4 Sep 2025 10:33:45 +0800
From: Wang Liang <wangliang74@...wei.com>
To: <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
	<npitre@...libre.com>
CC: <yuehaibing@...wei.com>, <zhangchangzhong@...wei.com>,
	<wangliang74@...wei.com>, <linux-serial@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH] vt: remove redundant check on vc_mode in con_font_set()

Previous commit edab558feba1 ("vt: sort out locking for font handling")
move the vc_mode check into console_lock protect, but forget to remove the
old check in con_font_set(). Just remove the redundant check.

Signed-off-by: Wang Liang <wangliang74@...wei.com>
---
 drivers/tty/vt/vt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 62049ceb34de..e4ae86d7da58 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -4855,8 +4855,6 @@ static int con_font_set(struct vc_data *vc, const struct console_font_op *op)
 	int size;
 	unsigned int vpitch = op->op == KD_FONT_OP_SET_TALL ? op->height : 32;
 
-	if (vc->vc_mode != KD_TEXT)
-		return -EINVAL;
 	if (!op->data)
 		return -EINVAL;
 	if (op->charcount > max_font_glyphs)
-- 
2.33.0