linux-kernel - Re: [PATCH v2] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jTPFnb_W4eWN=o5UnAjSOGn5cLiQgmZ81YE9moy39_TQ@mail.gmail.com>
Date: Thu, 4 Sep 2025 20:20:55 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Daniel Tang <danielzgtg.opensource@...il.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v2] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT

On Thu, Aug 28, 2025 at 10:13 AM Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
>
> On Thu, Aug 28, 2025 at 01:38:14AM -0400, Daniel Tang wrote:
> > Previously, after `rmmod acpi_tad`, `modprobe acpi_tad` would fail
> > with this dmesg:
> >
> > sysfs: cannot create duplicate filename '/devices/platform/ACPI000E:00/time'
> > Call Trace:
> >  <TASK>
> >  dump_stack_lvl+0x6c/0x90
> >  dump_stack+0x10/0x20
> >  sysfs_warn_dup+0x8b/0xa0
> >  sysfs_add_file_mode_ns+0x122/0x130
> >  internal_create_group+0x1dd/0x4c0
> >  sysfs_create_group+0x13/0x20
> >  acpi_tad_probe+0x147/0x1f0 [acpi_tad]
> >  platform_probe+0x42/0xb0
> >  </TASK>
> > acpi-tad ACPI000E:00: probe with driver acpi-tad failed with error -17
> >
> > Fixes: 3230b2b3c1ab ("ACPI: TAD: Add low-level support for real time capability")
> > Signed-off-by: Daniel Tang <danielzgtg.opensource@...il.com>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Applied as 6.18 material, thanks!