linux-kernel - [PATCH -next] tty/vt: Add missing return value for VT_RESIZE in vt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250904023955.3892120-1-wozizhi@huaweicloud.com>
Date: Thu,  4 Sep 2025 10:39:55 +0800
From: Zizhi Wo <wozizhi@...weicloud.com>
To: gregkh@...uxfoundation.org,
	jirislaby@...nel.org,
	npitre@...libre.com
Cc: linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org,
	yangerkun@...wei.com,
	wozizhi@...weicloud.com
Subject: [PATCH -next] tty/vt: Add missing return value for VT_RESIZE in vt_ioctl()

In vt_ioctl(), the handler for VT_RESIZE always returns 0, which prevents
users from detecting errors. Add the missing return value so that errors
can be properly reported to users like vt_resizex().

Signed-off-by: Zizhi Wo <wozizhi@...weicloud.com>
---
 drivers/tty/vt/vt_ioctl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index c9f11c4bd9fe..28993a3d0acb 100644
--- a/drivers/tty/vt/vt_ioctl.c
+++ b/drivers/tty/vt/vt_ioctl.c
@@ -908,7 +908,9 @@ int vt_ioctl(struct tty_struct *tty,
 
 			if (vc) {
 				/* FIXME: review v tty lock */
-				__vc_resize(vc_cons[i].d, cc, ll, true);
+				ret = __vc_resize(vc_cons[i].d, cc, ll, true);
+				if (ret)
+					return ret;
 			}
 		}
 		break;
-- 
2.39.2