linux-kernel - Re: [PATCH v3 1/3] PM: Make pm_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gmDnEr_WtVarWRTFWNTzK+fg9jTTD9FXJ5dTwGH0jPRQ@mail.gmail.com>
Date: Thu, 4 Sep 2025 21:06:44 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Samuel Wu <wusamuel@...gle.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Pavel Machek <pavel@...nel.org>, Len Brown <lenb@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Danilo Krummrich <dakr@...nel.org>, kernel-team@...roid.com, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Saravana Kannan <saravanak@...gle.com>
Subject: Re: [PATCH v3 1/3] PM: Make pm_wakeup_clear() call more clear

On Thu, Aug 21, 2025 at 2:42 AM Samuel Wu <wusamuel@...gle.com> wrote:
>
> Move pm_wakeup_clear() to the same location as other functions that do
> bookkeeping prior to suspend_prepare(). Since calling pm_wakeup_clear()
> is a prerequisite to setting up for suspend and enabling functionalities
> of suspend (like aborting during suspend), moving pm_wakeup_clear()
> higher up the call stack makes its intent more clear and obvious that it
> is called prior to suspend_prepare().
>
> With this patch, there is a slightly larger window when abort events
> can be registered, but otherwise suspend functionality is the same.
>
> Suggested-by: Saravana Kannan <saravanak@...gle.com>
> Signed-off-by: Samuel Wu <wusamuel@...gle.com>
> ---
>  kernel/power/process.c | 1 -
>  kernel/power/suspend.c | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index dc0dfc349f22..8ff68ebaa1e0 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -132,7 +132,6 @@ int freeze_processes(void)
>         if (!pm_freezing)
>                 static_branch_inc(&freezer_active);
>
> -       pm_wakeup_clear(0);
>         pm_freezing = true;
>         error = try_to_freeze_tasks(true);
>         if (!error)
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
> index b4ca17c2fecf..4bb4686c1c08 100644
> --- a/kernel/power/suspend.c
> +++ b/kernel/power/suspend.c
> @@ -595,6 +595,7 @@ static int enter_state(suspend_state_t state)
>         }
>
>         pm_pr_dbg("Preparing system for sleep (%s)\n", mem_sleep_labels[state]);
> +       pm_wakeup_clear(0);
>         pm_suspend_clear_flags();
>         error = suspend_prepare(state);
>         if (error)
> --

Applied as 6.18 material with Saravana's R-by and minor edits in the
subject and changelog.

Thanks!