linux-kernel - Re: [PATCH 2/2] drm/panel: himax-hx83102: add panel starry xr109ia2t

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <to4alnxchf56lkvguacmh35bquzbczlonhqi5xoi33alufu36j@4cgkzx3sgzod>
Date: Thu, 4 Sep 2025 23:45:18 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Vladimir Yakovlev <vovchkir@...il.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
        Jessica Zhang <quic_jesszhan@...cinc.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Cong Yang <yangcong5@...qin.corp-partner.google.com>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/panel: himax-hx83102: add panel starry xr109ia2t

On Thu, Sep 04, 2025 at 03:22:32AM +0300, Vladimir Yakovlev wrote:
> The STARRY XR109AI2T is a 10.95" 1200x2000 (WUXGA+) TFT LCD panel with
> himax-hx83102 controller. Hence, we add a new compatible with panel
> specific config.
> 
> Signed-off-by: Vladimir Yakovlev <vovchkir@...il.com>
> ---
>  drivers/gpu/drm/panel/panel-himax-hx83102.c | 193 ++++++++++++++++++++
>  1 file changed, 193 insertions(+)
> 

> +
> +	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83102_SETPOWER, 0x2C, 0xB1,
> +				     0xB1, 0x2D, 0xED, 0x32, 0xD7, 0x43, 0x36,
> +				     0x36, 0x36, 0x36);

The rest of the file uses lower case hex. Could you please follow the
pattern? The rest LGTM.


> +	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83102_SETSPCCMD, 0xD9);

-- 
With best wishes
Dmitry