| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <c80e6933-8985-4da4-8498-66cedaa87b1f@oss.qualcomm.com>
Date: Thu, 4 Sep 2025 14:35:14 -0700
From: Jessica Zhang <jessica.zhang@....qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
Rob Clark <robin.clark@....qualcomm.com>,
Dmitry Baryshkov
<lumag@...nel.org>,
Abhinav Kumar <abhinav.kumar@...ux.dev>, Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Jordan Crouse <jordan@...micpenguin.net>
Cc: linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/12] drm/msm/disp: set num_planes and fetch_mode in
INTERLEAVED_RGB_FMT
On 7/4/2025 7:47 PM, Dmitry Baryshkov wrote:
> All interleaved RGB formats use only 1 plane and MDP_FETCH_LINEAR.
> Specify num_planes and fetch_mode directly in the macro and remove
> unused parameters.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Reviewed-by: Jessica Zhang <jessica.zhang@....qualcomm.com>
> ---
> drivers/gpu/drm/msm/disp/mdp_format.c | 114 ++++++++++++----------------------
> 1 file changed, 39 insertions(+), 75 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp_format.c b/drivers/gpu/drm/msm/disp/mdp_format.c
> index eebedb1a2636e76996cf82847b7d391cb67b0941..26be35572fd2ee7456401aa525cc36025bc52ee4 100644
> --- a/drivers/gpu/drm/msm/disp/mdp_format.c
> +++ b/drivers/gpu/drm/msm/disp/mdp_format.c
> @@ -67,7 +67,7 @@ static struct csc_cfg csc_convert[CSC_MAX] = {
> #define MDP_TILE_HEIGHT_NV12 8
>
> #define INTERLEAVED_RGB_FMT(fmt, a, r, g, b, e0, e1, e2, e3, uc, alpha, \
> -bp, flg, fm, np) \
> +bp, flg) \
> { \
> .pixel_format = DRM_FORMAT_ ## fmt, \
> .fetch_type = MDP_PLANE_INTERLEAVED, \
> @@ -80,9 +80,9 @@ bp, flg, fm, np) \
> .chroma_sample = CHROMA_FULL, \
> .unpack_count = uc, \
> .bpp = bp, \
> - .fetch_mode = fm, \
> + .fetch_mode = MDP_FETCH_LINEAR, \
> .flags = MSM_FORMAT_FLAG_UNPACK_TIGHT | flg, \
> - .num_planes = np, \
> + .num_planes = 1, \
> .tile_height = MDP_TILE_HEIGHT_DEFAULT \
> }
>
> @@ -228,218 +228,182 @@ static const struct msm_format mdp_formats[] = {
> INTERLEAVED_RGB_FMT(ARGB8888,
> BPC8A, BPC8, BPC8, BPC8,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C3_ALPHA, 4,
> - true, 4, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 4, 0),
>
> INTERLEAVED_RGB_FMT(ABGR8888,
> BPC8A, BPC8, BPC8, BPC8,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4,
> - true, 4, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 4, 0),
>
> INTERLEAVED_RGB_FMT(XBGR8888,
> BPC8A, BPC8, BPC8, BPC8,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4,
> - false, 4, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 4, 0),
>
> INTERLEAVED_RGB_FMT(RGBA8888,
> BPC8A, BPC8, BPC8, BPC8,
> C3_ALPHA, C1_B_Cb, C0_G_Y, C2_R_Cr, 4,
> - true, 4, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 4, 0),
>
> INTERLEAVED_RGB_FMT(BGRA8888,
> BPC8A, BPC8, BPC8, BPC8,
> C3_ALPHA, C2_R_Cr, C0_G_Y, C1_B_Cb, 4,
> - true, 4, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 4, 0),
>
> INTERLEAVED_RGB_FMT(BGRX8888,
> BPC8A, BPC8, BPC8, BPC8,
> C3_ALPHA, C2_R_Cr, C0_G_Y, C1_B_Cb, 4,
> - false, 4, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 4, 0),
>
> INTERLEAVED_RGB_FMT(XRGB8888,
> BPC8A, BPC8, BPC8, BPC8,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C3_ALPHA, 4,
> - false, 4, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 4, 0),
>
> INTERLEAVED_RGB_FMT(RGBX8888,
> BPC8A, BPC8, BPC8, BPC8,
> C3_ALPHA, C1_B_Cb, C0_G_Y, C2_R_Cr, 4,
> - false, 4, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 4, 0),
>
> INTERLEAVED_RGB_FMT(RGB888,
> 0, BPC8, BPC8, BPC8,
> C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
> - false, 3, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 3, 0),
>
> INTERLEAVED_RGB_FMT(BGR888,
> 0, BPC8, BPC8, BPC8,
> C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
> - false, 3, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 3, 0),
>
> INTERLEAVED_RGB_FMT(RGB565,
> 0, BPC5, BPC6, BPC5,
> C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(BGR565,
> 0, BPC5, BPC6, BPC5,
> C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(ARGB1555,
> BPC1A, BPC5, BPC5, BPC5,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C3_ALPHA, 4,
> - true, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 2, 0),
>
> INTERLEAVED_RGB_FMT(ABGR1555,
> BPC1A, BPC5, BPC5, BPC5,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4,
> - true, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 2, 0),
>
> INTERLEAVED_RGB_FMT(RGBA5551,
> BPC1A, BPC5, BPC5, BPC5,
> C3_ALPHA, C1_B_Cb, C0_G_Y, C2_R_Cr, 4,
> - true, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 2, 0),
>
> INTERLEAVED_RGB_FMT(BGRA5551,
> BPC1A, BPC5, BPC5, BPC5,
> C3_ALPHA, C2_R_Cr, C0_G_Y, C1_B_Cb, 4,
> - true, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 2, 0),
>
> INTERLEAVED_RGB_FMT(XRGB1555,
> BPC1A, BPC5, BPC5, BPC5,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C3_ALPHA, 4,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(XBGR1555,
> BPC1A, BPC5, BPC5, BPC5,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(RGBX5551,
> BPC1A, BPC5, BPC5, BPC5,
> C3_ALPHA, C1_B_Cb, C0_G_Y, C2_R_Cr, 4,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(BGRX5551,
> BPC1A, BPC5, BPC5, BPC5,
> C3_ALPHA, C2_R_Cr, C0_G_Y, C1_B_Cb, 4,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(ARGB4444,
> BPC4A, BPC4, BPC4, BPC4,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C3_ALPHA, 4,
> - true, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 2, 0),
>
> INTERLEAVED_RGB_FMT(ABGR4444,
> BPC4A, BPC4, BPC4, BPC4,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4,
> - true, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 2, 0),
>
> INTERLEAVED_RGB_FMT(RGBA4444,
> BPC4A, BPC4, BPC4, BPC4,
> C3_ALPHA, C1_B_Cb, C0_G_Y, C2_R_Cr, 4,
> - true, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 2, 0),
>
> INTERLEAVED_RGB_FMT(BGRA4444,
> BPC4A, BPC4, BPC4, BPC4,
> C3_ALPHA, C2_R_Cr, C0_G_Y, C1_B_Cb, 4,
> - true, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + true, 2, 0),
>
> INTERLEAVED_RGB_FMT(XRGB4444,
> BPC4A, BPC4, BPC4, BPC4,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C3_ALPHA, 4,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(XBGR4444,
> BPC4A, BPC4, BPC4, BPC4,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(RGBX4444,
> BPC4A, BPC4, BPC4, BPC4,
> C3_ALPHA, C1_B_Cb, C0_G_Y, C2_R_Cr, 4,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(BGRX4444,
> BPC4A, BPC4, BPC4, BPC4,
> C3_ALPHA, C2_R_Cr, C0_G_Y, C1_B_Cb, 4,
> - false, 2, 0,
> - MDP_FETCH_LINEAR, 1),
> + false, 2, 0),
>
> INTERLEAVED_RGB_FMT(BGRA1010102,
> BPC8A, BPC8, BPC8, BPC8,
> C3_ALPHA, C2_R_Cr, C0_G_Y, C1_B_Cb, 4,
> - true, 4, MSM_FORMAT_FLAG_DX,
> - MDP_FETCH_LINEAR, 1),
> + true, 4, MSM_FORMAT_FLAG_DX),
>
> INTERLEAVED_RGB_FMT(RGBA1010102,
> BPC8A, BPC8, BPC8, BPC8,
> C3_ALPHA, C1_B_Cb, C0_G_Y, C2_R_Cr, 4,
> - true, 4, MSM_FORMAT_FLAG_DX,
> - MDP_FETCH_LINEAR, 1),
> + true, 4, MSM_FORMAT_FLAG_DX),
>
> INTERLEAVED_RGB_FMT(ABGR2101010,
> BPC8A, BPC8, BPC8, BPC8,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4,
> - true, 4, MSM_FORMAT_FLAG_DX,
> - MDP_FETCH_LINEAR, 1),
> + true, 4, MSM_FORMAT_FLAG_DX),
>
> INTERLEAVED_RGB_FMT(ARGB2101010,
> BPC8A, BPC8, BPC8, BPC8,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C3_ALPHA, 4,
> - true, 4, MSM_FORMAT_FLAG_DX,
> - MDP_FETCH_LINEAR, 1),
> + true, 4, MSM_FORMAT_FLAG_DX),
>
> INTERLEAVED_RGB_FMT(XRGB2101010,
> BPC8A, BPC8, BPC8, BPC8,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C3_ALPHA, 4,
> - false, 4, MSM_FORMAT_FLAG_DX,
> - MDP_FETCH_LINEAR, 1),
> + false, 4, MSM_FORMAT_FLAG_DX),
>
> INTERLEAVED_RGB_FMT(BGRX1010102,
> BPC8A, BPC8, BPC8, BPC8,
> C3_ALPHA, C2_R_Cr, C0_G_Y, C1_B_Cb, 4,
> - false, 4, MSM_FORMAT_FLAG_DX,
> - MDP_FETCH_LINEAR, 1),
> + false, 4, MSM_FORMAT_FLAG_DX),
>
> INTERLEAVED_RGB_FMT(XBGR2101010,
> BPC8A, BPC8, BPC8, BPC8,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C3_ALPHA, 4,
> - false, 4, MSM_FORMAT_FLAG_DX,
> - MDP_FETCH_LINEAR, 1),
> + false, 4, MSM_FORMAT_FLAG_DX),
>
> INTERLEAVED_RGB_FMT(RGBX1010102,
> BPC8A, BPC8, BPC8, BPC8,
> C3_ALPHA, C1_B_Cb, C0_G_Y, C2_R_Cr, 4,
> - false, 4, MSM_FORMAT_FLAG_DX,
> - MDP_FETCH_LINEAR, 1),
> + false, 4, MSM_FORMAT_FLAG_DX),
>
> /* --- RGB formats above / YUV formats below this line --- */
>
>
Powered by blists - more mailing lists