linux-kernel - Re: [PATCH 10/37] dt-bindings: i2c: apple,i2c: Add apple,t6020-i2c compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5o23zrqe2ei3bmwlxokhtkgfpeki6ctoq3ahd4f66utfu5hdk@6q55hvy4hvq4>
Date: Fri, 5 Sep 2025 00:52:20 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Janne Grunau <j@...nau.net>
Cc: Sven Peter <sven@...nel.org>, Alyssa Rosenzweig <alyssa@...enzweig.io>, 
	Neal Gompa <neal@...pa.dev>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Hector Martin <marcan@...can.st>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Viresh Kumar <viresh.kumar@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>, 
	Robin Murphy <robin.murphy@....com>, Linus Walleij <linus.walleij@...aro.org>, 
	Mark Kettenis <kettenis@...nbsd.org>, Jassi Brar <jassisinghbrar@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Sasha Finkelstein <fnkl.kernel@...il.com>, 
	Marcel Holtmann <marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
	Johannes Berg <johannes@...solutions.net>, van Spriel <arend@...adcom.com>, Lee Jones <lee@...nel.org>, 
	Uwe Kleine-König <ukleinek@...nel.org>, Stephen Boyd <sboyd@...nel.org>, 
	Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck <linux@...ck-us.net>, 
	Michael Turquette <mturquette@...libre.com>, Martin Povišer <povik+lin@...ebit.org>, 
	Vinod Koul <vkoul@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Marc Zyngier <maz@...nel.org>, 
	Ulf Hansson <ulf.hansson@...aro.org>, Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>, 
	Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, asahi@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, iommu@...ts.linux.dev, linux-gpio@...r.kernel.org, 
	linux-i2c@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-bluetooth@...r.kernel.org, 
	linux-wireless@...r.kernel.org, linux-pwm@...r.kernel.org, linux-watchdog@...r.kernel.org, 
	linux-clk@...r.kernel.org, dmaengine@...r.kernel.org, linux-sound@...r.kernel.org, 
	linux-spi@...r.kernel.org, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH 10/37] dt-bindings: i2c: apple,i2c: Add apple,t6020-i2c
 compatible

Hi Janne,

On Thu, Aug 28, 2025 at 04:01:29PM +0200, Janne Grunau wrote:
> After discussion with the devicetree maintainers we agreed to not extend
> lists with the generic compatible "apple,i2c" anymore [1]. Use
> "apple,t8103-i2c" as fallback compatible as it is the SoC the driver
> and bindings were written for.
> 
> This block is compatible with t8103, so just add the new per-SoC
> compatible using apple,t8103-i2c as base.
> 
> [1]: https://lore.kernel.org/asahi/12ab93b7-1fc2-4ce0-926e-c8141cfe81bf@kernel.org/
> 
> Signed-off-by: Janne Grunau <j@...nau.net>

Acked-by: Andi Shyti <andi.shyti@...nel.org>

Andi

> ---
>  .../devicetree/bindings/i2c/apple,i2c.yaml         | 27 +++++++++++++---------
>  1 file changed, 16 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> index fed3e1b8c43f67b8f5a19e5c1e046b0e17ab8017..500a965bdb7a84e4997b52e8c19dcc1a7ee0cff7 100644
> --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> @@ -20,17 +20,22 @@ allOf:
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - apple,s5l8960x-i2c
> -          - apple,t7000-i2c
> -          - apple,s8000-i2c
> -          - apple,t8010-i2c
> -          - apple,t8015-i2c
> -          - apple,t8103-i2c
> -          - apple,t8112-i2c
> -          - apple,t6000-i2c
> -      - const: apple,i2c
> +    oneOf:
> +      - items:
> +          - const: apple,t6020-i2c
> +          - const: apple,t8103-i2c
> +      - items:
> +          - enum:
> +              # Do not add additional SoC to this list.
> +              - apple,s5l8960x-i2c
> +              - apple,t7000-i2c
> +              - apple,s8000-i2c
> +              - apple,t8010-i2c
> +              - apple,t8015-i2c
> +              - apple,t8103-i2c
> +              - apple,t8112-i2c
> +              - apple,t6000-i2c
> +          - const: apple,i2c
>  
>    reg:
>      maxItems: 1
> 
> -- 
> 2.51.0
>