linux-kernel - Re: [PATCH v2 5/5] PCI: qcom: Allow pwrctrl core to toggle PERST# for new DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509041110.4DgQKyf1-lkp@intel.com>
Date: Thu, 4 Sep 2025 11:19:30 +0800
From: kernel test robot <lkp@...el.com>
To: Manivannan Sadhasivam via B4 Relay <devnull+manivannan.sadhasivam.oss.qualcomm.com@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <helgaas@...nel.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Saravana Kannan <saravanak@...gle.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org,
	Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>,
	Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH v2 5/5] PCI: qcom: Allow pwrctrl core to toggle PERST#
 for new DT binding

Hi Manivannan,

kernel test robot noticed the following build errors:

[auto build test ERROR on 8f5ae30d69d7543eee0d70083daf4de8fe15d585]

url:    https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam-via-B4-Relay/PCI-qcom-Wait-for-PCIE_RESET_CONFIG_WAIT_MS-after-PERST-deassert/20250903-151623
base:   8f5ae30d69d7543eee0d70083daf4de8fe15d585
patch link:    https://lore.kernel.org/r/20250903-pci-pwrctrl-perst-v2-5-2d461ed0e061%40oss.qualcomm.com
patch subject: [PATCH v2 5/5] PCI: qcom: Allow pwrctrl core to toggle PERST# for new DT binding
config: i386-buildonly-randconfig-002-20250904 (https://download.01.org/0day-ci/archive/20250904/202509041110.4DgQKyf1-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250904/202509041110.4DgQKyf1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509041110.4DgQKyf1-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/pci/controller/dwc/pcie-qcom.c: In function 'qcom_pcie_host_init':
>> drivers/pci/controller/dwc/pcie-qcom.c:1405:23: error: 'struct pci_host_bridge' has no member named 'toggle_perst'
    1405 |         pci->pp.bridge->toggle_perst = qcom_pcie_toggle_perst;
         |                       ^~


vim +1405 drivers/pci/controller/dwc/pcie-qcom.c

  1368	
  1369	static int qcom_pcie_host_init(struct dw_pcie_rp *pp)
  1370	{
  1371		struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
  1372		struct qcom_pcie *pcie = to_qcom_pcie(pci);
  1373		int ret;
  1374	
  1375		qcom_ep_reset_assert(pcie, NULL);
  1376	
  1377		ret = pcie->cfg->ops->init(pcie);
  1378		if (ret)
  1379			return ret;
  1380	
  1381		ret = qcom_pcie_phy_power_on(pcie);
  1382		if (ret)
  1383			goto err_deinit;
  1384	
  1385		if (pcie->cfg->ops->post_init) {
  1386			ret = pcie->cfg->ops->post_init(pcie);
  1387			if (ret)
  1388				goto err_disable_phy;
  1389		}
  1390	
  1391		/*
  1392		 * Only deassert PERST# for all devices here if legacy binding is used.
  1393		 * For the new binding, pwrctrl driver is expected to toggle PERST# for
  1394		 * individual devices.
  1395		 */
  1396		if (list_empty(&pcie->perst))
  1397			qcom_ep_reset_deassert(pcie, NULL);
  1398	
  1399		if (pcie->cfg->ops->config_sid) {
  1400			ret = pcie->cfg->ops->config_sid(pcie);
  1401			if (ret)
  1402				goto err_assert_reset;
  1403		}
  1404	
> 1405		pci->pp.bridge->toggle_perst = qcom_pcie_toggle_perst;
  1406	
  1407		return 0;
  1408	
  1409	err_assert_reset:
  1410		qcom_ep_reset_assert(pcie, NULL);
  1411	err_disable_phy:
  1412		qcom_pcie_phy_power_off(pcie);
  1413	err_deinit:
  1414		pcie->cfg->ops->deinit(pcie);
  1415	
  1416		return ret;
  1417	}
  1418	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki