linux-kernel - Re: [PATCH] drivers/misc/amd-sbi/Kconfig: select REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b43dcd31-93c8-4fd8-8ecb-60dead19470a@amd.com>
Date: Thu, 4 Sep 2025 11:26:01 +0530
From: "Gupta, Akshay" <Akshay.Gupta@....com>
To: Max Kellermann <max.kellermann@...os.com>, arnd@...db.de,
 gregkh@...uxfoundation.org, naveenkrishna.chatradhi@....com,
 linux@...ck-us.net, linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH] drivers/misc/amd-sbi/Kconfig: select REGMAP_I2C


On 8/29/2025 2:44 PM, Max Kellermann wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Without CONFIG_REGMAP, rmi-i2c.c fails to build because struct
> regmap_config is not defined:
>
>   drivers/misc/amd-sbi/rmi-i2c.c: In function ‘sbrmi_i2c_probe’:
>   drivers/misc/amd-sbi/rmi-i2c.c:57:16: error: variable ‘sbrmi_i2c_regmap_config’ has initializer but incomplete type
>      57 |         struct regmap_config sbrmi_i2c_regmap_config = {
>         |                ^~~~~~~~~~~~~
>
> Additionally, CONFIG_REGMAP_I2C is needed for devm_regmap_init_i2c():
>
>   ld: drivers/misc/amd-sbi/rmi-i2c.o: in function `sbrmi_i2c_probe':
>   drivers/misc/amd-sbi/rmi-i2c.c:69:(.text+0x1c0): undefined reference to `__devm_regmap_init_i2c'
>
> Fixes: 013f7e7131bd ("misc: amd-sbi: Use regmap subsystem")
> Cc: stable@...r.kernel.org
> Signed-off-by: Max Kellermann <max.kellermann@...os.com>
> ---
>   drivers/misc/amd-sbi/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/amd-sbi/Kconfig b/drivers/misc/amd-sbi/Kconfig
> index 4840831c84ca..4aae0733d0fc 100644
> --- a/drivers/misc/amd-sbi/Kconfig
> +++ b/drivers/misc/amd-sbi/Kconfig
> @@ -2,6 +2,7 @@
>   config AMD_SBRMI_I2C
>          tristate "AMD side band RMI support"
>          depends on I2C
> +       select REGMAP_I2C
>          help
>            Side band RMI over I2C support for AMD out of band management.
>
> --
> 2.47.2

Thank you for the patch.

Tested-by: Akshay Gupta <Akshay.Gupta@....com>

Reviewed-by: Akshay Gupta <Akshay.Gupta@....com>