[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c5dd1c02-8538-4b9f-a453-d18e7a30ae30@ti.com>
Date: Thu, 4 Sep 2025 11:32:40 +0530
From: Sebin Francis <sebin.francis@...com>
To: Akashdeep Kaur <a-kaur@...com>, <praneeth@...com>, <nm@...com>,
<afd@...com>, <vigneshr@...com>, <d-gole@...com>, <kristo@...nel.org>,
<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
CC: <vishalm@...com>
Subject: Re: [PATCH v3 3/3] arm64: dts: ti: k3-pinctrl: Add the remaining
macros
Hi Akash,
On 02/09/25 12:49, Akashdeep Kaur wrote:
> Add the drive stregth, schmitt trigger enable macros to pinctrl file.
> Add the missing macros for DeepSleep configuration control referenced
> from "Table 14-6172. Description Of The Pad Configuration Register Bits"
> in AM625 TRM[0].
> Add some DeepSleep macros to provide combinations that can be used
> directly in device tree files example PIN_DS_OUTPUT_LOW that
> configures pin to be output and also sets its value to 0.
>
> [0] https://www.ti.com/lit/ug/spruiv7b/spruiv7b.pdf
>
> Signed-off-by: Akashdeep Kaur <a-kaur@...com>
...
> +#define DS_OUT_VALUE_ZERO (0 << DS_OUT_VAL_SHIFT)
> +#define DS_OUT_VALUE_ONE (1 << DS_OUT_VAL_SHIFT)
> +
> +#define WKUP_ENABLE (1 << WKUP_EN_SHIFT)
> +#define WKUP_ON_LEVEL (1 << WKUP_LVL_EN_SHIFT)
> +#define WKUP_ON_EDGE (0 << WKUP_LVL_EN_SHIFT)
> +#define WKUP_LEVEL_LOW (0 << WKUP_LVL_POL_SHIFT)
> +#define WKUP_LEVEL_HIGH (1 << WKUP_LVL_POL_SHIFT)
> +
> +#define WKUP_DISABLE (0 << WKUP_EN_SHIFT)
This can be moved below WKUP_ENABLE macro to be consistent
> +
> /* Only these macros are expected be used directly in device tree files */
> #define PIN_OUTPUT (INPUT_DISABLE | PULL_DISABLE)
> #define PIN_OUTPUT_PULLUP (INPUT_DISABLE | PULL_UP)
> @@ -53,18 +79,41 @@
> #define PIN_DEBOUNCE_CONF5 (5 << DEBOUNCE_SHIFT)
> #define PIN_DEBOUNCE_CONF6 (6 << DEBOUNCE_SHIFT)
>
> +#define PIN_DRIVE_STRENGTH_NOMINAL (0 << DRV_STR_SHIFT)
> +#define PIN_DRIVE_STRENGTH_SLOW (1 << DRV_STR_SHIFT)
> +#define PIN_DRIVE_STRENGTH_FAST (2 << DRV_STR_SHIFT)
...
> +#define DS_STATE_VAL (1 << DS_EN_SHIFT)
> +#define ACTIVE_STATE_VAL (0 << DS_EN_SHIFT)
These can be moved to the top before PIN_* and can be renamed to
DS_STATE_EN and DS_STATE_DIS
> +
> +#define PIN_DS_OUTPUT_LOW (DS_STATE_VAL | DS_INPUT_DISABLE | DS_OUT_VALUE_ZERO)
> +#define PIN_DS_OUTPUT_HIGH (DS_STATE_VAL | DS_INPUT_DISABLE | DS_OUT_VALUE_ONE)
> +#define PIN_DS_INPUT (DS_STATE_VAL | DS_INPUT_EN | DS_PULL_DISABLE)
> +#define PIN_DS_INPUT_PULLUP (DS_STATE_VAL | DS_INPUT_EN | DS_PULL_UP)
> +#define PIN_DS_INPUT_PULLDOWN (DS_STATE_VAL | DS_INPUT_EN | DS_PULL_DOWN)
> +
> +#define PIN_WKUP_EN_EDGE (WKUP_ENABLE | WKUP_ON_EDGE)
> +#define PIN_WKUP_EN_LEVEL_LOW (WKUP_ENABLE | WKUP_ON_LEVEL | WKUP_LEVEL_LOW)
> +#define PIN_WKUP_EN_LEVEL_HIGH (WKUP_ENABLE | WKUP_ON_LEVEL | WKUP_LEVEL_HIGH)
> +#define PIN_WKUP_EN WKUP_EN_EDGE
As EDGE wake is used commonly we can use the PIN_WKUP_EN_EDGE in this case
>
> /* Default mux configuration for gpio-ranges to use with pinctrl */
> #define PIN_GPIO_RANGE_IOPAD (PIN_INPUT | 7)
Thanks
Sebin
Powered by blists - more mailing lists