linux-kernel - RE: [PATCH v7 2/2] perf: Fujitsu: Add the Uncore PCI PMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OSCPR01MB12819D172FC89A6A8C26226DCC100A@OSCPR01MB12819.jpnprd01.prod.outlook.com>
Date: Thu, 4 Sep 2025 06:41:47 +0000
From: "Koichi Okuno (Fujitsu)" <fj2767dz@...itsu.com>
To: 'Robin Murphy' <robin.murphy@....com>
CC: Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>,
	Jonathan Corbet <corbet@....net>, Catalin Marinas <catalin.marinas@....com>,
	Gowthami Thiagarajan <gthiagarajan@...vell.com>, Linu Cherian
	<lcherian@...vell.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Bjorn Andersson
	<quic_bjorande@...cinc.com>, Geert Uytterhoeven <geert+renesas@...der.be>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Konrad Dybcio
	<konradybcio@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>, Arnd
 Bergmann <arnd@...db.de>, Nícolas F. R. A. Prado
	<nfraprado@...labora.com>, Thomas Gleixner <tglx@...utronix.de>, Peter
 Zijlstra <peterz@...radead.org>, Jonathan Cameron
	<Jonathan.Cameron@...wei.com>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Koichi Okuno (Fujitsu)"
	<fj2767dz@...itsu.com>
Subject: RE: [PATCH v7 2/2] perf: Fujitsu: Add the Uncore PCI PMU driver

Hi, Robin

> > This adds a new dynamic PMU to the Perf Events framework to program and
> > control the Uncore PCI PMUs in Fujitsu chips.
> > 
> > This driver was created with reference to drivers/perf/qcom_l3_pmu.c.
> > 
> > This driver exports formatting and event information to sysfs so it can
> > be used by the perf user space tools with the syntaxes:
> > 
> > perf stat -e pci_iod0_pci0/ea-pci/ ls
> > perf stat -e pci_iod0_pci0/event=0x80/ ls
> > 
> > FUJITSU-MONAKA PMU Events Specification v1.1 URL:
> > https://github.com/fujitsu/FUJITSU-MONAKA
> > 
> > Signed-off-by: Koichi Okuno <fj2767dz@...itsu.com>
> > ---
> >   .../admin-guide/perf/fujitsu_pci_pmu.rst      |  50 ++
> >   Documentation/admin-guide/perf/index.rst      |   1 +
> >   drivers/perf/Kconfig                          |   9 +
> >   drivers/perf/Makefile                         |   1 +
> >   drivers/perf/fujitsu_pci_pmu.c                | 536 ++++++++++++++++++
> 
>  From a quick side-by-side skim, this is a copy-paste of the exact same 
> driver from patch #1 with s/mac/pci/g applied. Please don't do that. If 
> the hardware is functionally the same, then it should just be a single 
> driver that can then pick which PMU name and set of event alias 
> attributes to use for a given instance based on the ACPI HID match 
> (and/or any other ID register info you may have.)

I've integrated the MAC PMU driver and the PCI PMU driver into a single
driver in v8.

Best Regards,
Koichi Okuno